Adding batch size to custom service #5523
Conversation
|
Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
|
|
||
| export class CustomServiceSettings { | ||
| /** | ||
| * Specifies the batch size used for the semantic_text field. If the field is not provided, the default is 10. |
There was a problem hiding this comment.
Do we need to expand on this to explain what the batch size is? Something like "the batch size is the maximum number of inputs based on the selected chunking strategy for the semantic_text field" and then link out to the semantic text field? Or is that too much information for this location?
Separately, can we add a link to the semantic text page? it'd be an entry in specification/_doc_ids/table.csv for https://www.elastic.co/docs/reference/elasticsearch/mapping-reference/semantic-text#auto-text-chunking and then here we'd add the id for @ext_doc_id, looks like: https://github.com/elastic/elasticsearch-specification/blob/main/specification/transform/_types/Transform.ts#L139
There was a problem hiding this comment.
Yeah good idea.
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-5523-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 83b69f482863cba6e25f6f89a1dfaea0184b1f55
# Push it to GitHub
git push --set-upstream origin backport-5523-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.1 9.1
# Navigate to the new working tree
cd .worktrees/backport-9.1
# Create a new branch
git switch --create backport-5523-to-9.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 83b69f482863cba6e25f6f89a1dfaea0184b1f55
# Push it to GitHub
git push --set-upstream origin backport-5523-to-9.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.1Then, create a pull request where the |
* Adding batch size * Updating batch size info with link (cherry picked from commit 83b69f4)
* Adding batch size * Updating batch size info with link (cherry picked from commit 83b69f4)
* Adding batch size * Updating batch size info with link (cherry picked from commit 83b69f4)
2 participants
This PR updates the docs to include
batch_sizewhich I forgot to add.The original ES PR is here: elastic/elasticsearch#129558