Add support for multiple Google Model Garden providers for completion and chat_completion tasks #5532
Conversation
… and chat_completion tasks
Jan-Kazlouski-elastic
requested review from
DonalEvans,
dan-rubinstein,
jonathan-buttner and
pquentin
Jan-Kazlouski-elastic
added
specification
ml
skip-backport
|
Following you can find the validation changes against the target branch for the APIs.
You can validate these APIs yourself by using the |
| @@ -0,0 +1,14 @@ | |||
| summary: A completion task for Google Model Garden Meta endpoint with single URL provided | |||
There was a problem hiding this comment.
Could you add examples of the other providers?
That way it'll be more clear when a user needs to include url vs url and streaming_url.
There was a problem hiding this comment.
Added examples for the rest of the providers.
| export enum GoogleModelGardenProvider { | ||
| google, | ||
| anthropic | ||
| anthropic, |
There was a problem hiding this comment.
Could you also add in the url and streaming_url field comments which providers require which ones? (basically the same thing we did in the comment in the Java code).
There was a problem hiding this comment.
Added.
…odel Garden providers with single and separate streaming URLs
|
@jonathan-buttner your comments are addressed. Could you please take another look at this PR? |
2 participants
This PR adds changes to specification caused by elastic/elasticsearch#135701
Additional actions