Mark GeoLineAggregation sort as optional #5551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it's required most of the time, it's optional when in a sub-aggregation inside a time_series aggregation, as mentioned in the comment.
|
Following you can find the validation changes against the target branch for the API.
You can validate this API yourself by using the |
flobernd
approved these changes
Oct 28, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Oct 28, 2025
While it's required most of the time, it's optional when in a sub-aggregation inside a time_series aggregation, as mentioned in the comment. (cherry picked from commit c5e3b91)
pquentin
added a commit
that referenced
this pull request
Oct 28, 2025
While it's required most of the time, it's optional when in a sub-aggregation inside a time_series aggregation, as mentioned in the comment. (cherry picked from commit c5e3b91) Co-authored-by: Quentin Pradet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it's required most of the time, it's optional when in a sub-aggregation inside a time_series aggregation, as mentioned in the comment.
Sources:
Not backporting to 9.2 as it's a breaking change, but still backporting to 8.19 as it's not that bad for most clients.
Relates #3122