Skip to content

Allow single percent in PercentilesAggregation#5552

Merged
pquentin merged 1 commit intomainfrom
percentiles-agg-single-percent
Oct 30, 2025
Merged

Allow single percent in PercentilesAggregation#5552
pquentin merged 1 commit intomainfrom
percentiles-agg-single-percent

Conversation

@pquentin
Copy link
Member

I don't know if we actually want to do that, but that's possible.

First, percents is parsed in PercentilesAggregationBuilder but I don't understand where a single value is allowed

However there's a YAML test that uses this form, the response looks like this:

              "tdigest_percentiles#percentiles_agg": {
                "values": {
                  "50.0": null
                }
              },

However, since it's undocumented, I'm happy to ignore that test.

@pquentin pquentin added the skip-backport This pull request should not be backported label Oct 28, 2025
@github-actions
Copy link
Contributor

Following you can find the validation changes against the target branch for the API.

API Status Request Response
search 🔴 2593/2615 → 2594/2615 2615/2615

You can validate this API yourself by using the make validate target.

@flobernd
Copy link
Member

Would be fine for me. The "single or many" construct shouldn't even be breaking for the statically typing clients - so backport might be possible.

@pquentin pquentin added backport 8.19 backport 9.1 backport 9.2 and removed skip-backport This pull request should not be backported labels Oct 30, 2025
@pquentin pquentin merged commit 8bef67e into main Oct 30, 2025
17 checks passed
@pquentin pquentin deleted the percentiles-agg-single-percent branch October 30, 2025 12:35
github-actions bot pushed a commit that referenced this pull request Oct 30, 2025
github-actions bot pushed a commit that referenced this pull request Oct 30, 2025
github-actions bot pushed a commit that referenced this pull request Oct 30, 2025
pquentin added a commit that referenced this pull request Oct 30, 2025
(cherry picked from commit 8bef67e)

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
pquentin added a commit that referenced this pull request Oct 30, 2025
(cherry picked from commit 8bef67e)

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
pquentin added a commit that referenced this pull request Oct 30, 2025
(cherry picked from commit 8bef67e)

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants