Closed
Conversation
* Add initial rest-api-spec converter * Wrap JSON data with endpoint name * Add headers * Extract visibility * Add debug logging for types * Improve type handling * Extract builting mappings * Skip empty headers * Add more mappings * Add required field to bodies * Support CommonCatQueryParameters * Fix availability/stability * Improve urls generation * Serialize description only if required? * Support more complex types * Add spec and docs for new logs streams endpoints (#5258) * Add spec and docs for new logs streams endpoints * Add @codegen name to Acked responses * Linting fix * Update specification/streams/status/examples/200_response/GetStreamsStatusResponseExample1.yaml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Correct feature flag * Add doc-ids * Fix doc-ids * Update specification/_doc_ids/table.csv Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co> * Update specification/_doc_ids/table.csv Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co> * Add default timeouts --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co> * Update specification output * Add common cat API parameters for unit rendering (#5298) Describes the `?bytes=` and `?time=` parameters which are accepted by all the `GET _cat/...` APIs. * Edit the log streams endpoint docs (#5305) * Add speficaiton for a new rescore type (#5308) Based on PR elastic/elasticsearch#74274 * Update specification output * Update rest-api-spec (#5294) Co-authored-by: pquentin <42327+pquentin@users.noreply.github.com> * Update rest-api-spec (#5311) Co-authored-by: pquentin <42327+pquentin@users.noreply.github.com> * Commit Cargo.lock changes * Show unexpected union * Remove '| string' in query parameters * Always specify body.required * Fix type for uint * Return string for string | string[] * Skip empty descriptions * Remove redundant code comments * Specify default_value for expand_wildcards * Stop hardcoding expand_wildcards * Improve union handling * Hardcode "serialize": "bulk" endpoints * Handle deprecated URLs parts * Improve diff script * Tweak converter * Handle parameter visibility * Handle required parameters * Fix required parameters * Fix experimental indices sample APIs * Allow string[] for routing parameters * Fix type of if_version in ingest.put_pipeline * Fix type of search_type in rank_eval * Fix type of CategoryId * Mark find_structure column_names as string | string[] * Allow empty URLs * Handle number|string special cases * Handle Fleet IndexName | IndexCase case * Fail on unknown cases * Improve diff * Remvope file committed by mistake * Add optional body to three ML APIs * Fix ccs_minimize_roundtrips default value * Fix description for parameter that does not accept comma-separated values * Stop trying to document private API * Remove parameter in find_structure API * Fix find_stucture format enum * Remove cruft * Remove more cruft * Update Rust edition to 2024 and refactor conditional statements * Clarify main.rs Print at the correct place and use crate prefixes * Remove diplay() call * Add TODOs * Remove wrong doc_id from knn_search * Add body to project.tags * Run make spec-format-fix * wip * Switch to HttpMethod enum * Use http::Method and implement TryFrom * Use enums for stability and visibility * Switch parameter types to enum * Simplify BUILTING_MAPPINGS code * Add top-level Cargo.lock change * Add WASM integration for rest-api-spec generation * Fix leftovers from previous commit * Restrict WASM tracing to INFO * Add _common.json generation * Rename is_literal to get_literal * Fix indices.get_settings expand_wildcards default --------- Co-authored-by: Luke Whiting <luke.whiting@elastic.co> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: David Turner <david.turner@elastic.co> Co-authored-by: Lisa Cawley <lcawley@elastic.co> Co-authored-by: Mayya Sharipova <mayya.sharipova@elastic.co> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: pquentin <42327+pquentin@users.noreply.github.com> Co-authored-by: Laurent Saint-Félix <laurent.saintfelix@elastic.co> (cherry picked from commit 7b7e18a) # Conflicts: # compiler-rs/compiler-wasm-lib/pkg/compiler_wasm_lib_bg.wasm # specification/inference/put_groq/PutGroqRequest.ts # specification/inference/put_nvidia/PutNvidiaRequest.ts # specification/streams/logs_disable/StreamsLogsDisableRequest.ts # specification/streams/logs_enable/StreamsLogsEnableRequest.ts
Contributor
|
Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
Member
Author
|
Closing as value is unclear and there are breaking changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation