added ivf_format feature flag

Author: john-wagster

server/src/main/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapper.java

@@ -2552,7 +2552,6 @@ public Query createKnnQuery(
                     queryVector.asByteVector(),
                     k,
                     numCands,
-                    visitPercentage,
                     filter,
                     similarityThreshold,
                     parentFilter,
@@ -2575,7 +2574,6 @@ public Query createKnnQuery(
                     queryVector.asByteVector(),
                     k,
                     numCands,
-                    visitPercentage,
                     filter,
                     similarityThreshold,
                     parentFilter,
@@ -2597,7 +2595,6 @@ private Query createKnnBitQuery(
             byte[] queryVector,
             int k,
             int numCands,
-            float visitPercentage,
             Query filter,
             Float similarityThreshold,
             BitSetProducer parentFilter,
@@ -2637,7 +2634,6 @@ private Query createKnnByteQuery(
             byte[] queryVector,
             int k,
             int numCands,
-            float visitPercentage,
             Query filter,
             Float similarityThreshold,
             BitSetProducer parentFilter,

server/src/main/java/org/elasticsearch/search/retriever/KnnRetrieverBuilder.java

@@ -34,6 +34,7 @@
 import java.util.function.Supplier;
 
 import static org.elasticsearch.common.Strings.format;
+import static org.elasticsearch.index.mapper.vectors.DenseVectorFieldMapper.IVF_FORMAT;
 import static org.elasticsearch.xcontent.ConstructingObjectParser.constructorArg;
 import static org.elasticsearch.xcontent.ConstructingObjectParser.optionalConstructorArg;
 
@@ -91,7 +92,9 @@ public final class KnnRetrieverBuilder extends RetrieverBuilder {
         );
         PARSER.declareInt(constructorArg(), K_FIELD);
         PARSER.declareInt(constructorArg(), NUM_CANDS_FIELD);
-        PARSER.declareFloat(optionalConstructorArg(), VISIT_PERCENTAGE_FIELD);
+        if (IVF_FORMAT.isEnabled()) {
+            PARSER.declareFloat(optionalConstructorArg(), VISIT_PERCENTAGE_FIELD);
+        }
         PARSER.declareFloat(optionalConstructorArg(), VECTOR_SIMILARITY);
         PARSER.declareField(
             optionalConstructorArg(),

server/src/main/java/org/elasticsearch/search/vectors/KnnSearchBuilder.java

@@ -34,6 +34,7 @@
 
 import static org.elasticsearch.TransportVersions.V_8_11_X;
 import static org.elasticsearch.common.Strings.format;
+import static org.elasticsearch.index.mapper.vectors.DenseVectorFieldMapper.IVF_FORMAT;
 import static org.elasticsearch.index.query.AbstractQueryBuilder.DEFAULT_BOOST;
 import static org.elasticsearch.search.SearchService.DEFAULT_SIZE;
 import static org.elasticsearch.xcontent.ConstructingObjectParser.constructorArg;
@@ -82,7 +83,9 @@ public class KnnSearchBuilder implements Writeable, ToXContentFragment, Rewritea
         );
         PARSER.declareInt(optionalConstructorArg(), K_FIELD);
         PARSER.declareInt(optionalConstructorArg(), NUM_CANDS_FIELD);
-        PARSER.declareFloat(optionalConstructorArg(), VISIT_PERCENTAGE_FIELD);
+        if (IVF_FORMAT.isEnabled()) {
+            PARSER.declareFloat(optionalConstructorArg(), VISIT_PERCENTAGE_FIELD);
+        }
         PARSER.declareNamedObject(
             optionalConstructorArg(),
             (p, c, n) -> p.namedObject(QueryVectorBuilder.class, n, c),

server/src/main/java/org/elasticsearch/search/vectors/KnnSearchRequestParser.java

@@ -30,6 +30,7 @@
 import java.util.List;
 import java.util.Objects;
 
+import static org.elasticsearch.index.mapper.vectors.DenseVectorFieldMapper.IVF_FORMAT;
 import static org.elasticsearch.xcontent.ConstructingObjectParser.constructorArg;
 import static org.elasticsearch.xcontent.ConstructingObjectParser.optionalConstructorArg;
 
@@ -218,7 +219,9 @@ static class KnnSearch {
             PARSER.declareFloatArray(constructorArg(), QUERY_VECTOR_FIELD);
             PARSER.declareInt(constructorArg(), K_FIELD);
             PARSER.declareInt(constructorArg(), NUM_CANDS_FIELD);
-            PARSER.declareFloat(optionalConstructorArg(), VISIT_PERCENTAGE_FIELD);
+            if (IVF_FORMAT.isEnabled()) {
+                PARSER.declareFloat(optionalConstructorArg(), VISIT_PERCENTAGE_FIELD);
+            }
         }
 
         public static KnnSearch parse(XContentParser parser) throws IOException {

server/src/main/java/org/elasticsearch/search/vectors/KnnVectorQueryBuilder.java

@@ -48,6 +48,7 @@
 
 import static org.elasticsearch.TransportVersions.KNN_QUERY_RESCORE_OVERSAMPLE;
 import static org.elasticsearch.common.Strings.format;
+import static org.elasticsearch.index.mapper.vectors.DenseVectorFieldMapper.IVF_FORMAT;
 import static org.elasticsearch.search.SearchService.DEFAULT_SIZE;
 import static org.elasticsearch.xcontent.ConstructingObjectParser.constructorArg;
 import static org.elasticsearch.xcontent.ConstructingObjectParser.optionalConstructorArg;
@@ -96,7 +97,9 @@ public class KnnVectorQueryBuilder extends AbstractQueryBuilder<KnnVectorQueryBu
         );
         PARSER.declareInt(optionalConstructorArg(), K_FIELD);
         PARSER.declareInt(optionalConstructorArg(), NUM_CANDS_FIELD);
-        PARSER.declareFloat(optionalConstructorArg(), VISIT_PERCENTAGE_FIELD);
+        if (IVF_FORMAT.isEnabled()) {
+            PARSER.declareFloat(optionalConstructorArg(), VISIT_PERCENTAGE_FIELD);
+        }
         PARSER.declareFloat(optionalConstructorArg(), VECTOR_SIMILARITY_FIELD);
         PARSER.declareNamedObject(
             optionalConstructorArg(),