Skip to content

Commit 26ba14b

Browse files
committed
Update reason for suppressions
1 parent 61ac240 commit 26ba14b

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed

libs/core/src/main/java/org/elasticsearch/core/internal/provider/EmbeddedImplClassLoader.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -467,9 +467,7 @@ private static CodeSource codeSource(URL baseURL, String jarName) throws Malform
467467
return new CodeSource(new URL(baseURL, jarName), (CodeSigner[]) null /*signers*/);
468468
}
469469

470-
@SuppressForbidden(
471-
reason = "TODO Deprecate any lenient usage of Boolean#parseBoolean https://github.com/elastic/elasticsearch/issues/128993"
472-
)
470+
@SuppressForbidden(reason = "accept lenient manifest attributes")
473471
private static boolean isMultiRelease(ClassLoader parent, String jarPrefix) throws IOException {
474472
try (InputStream is = parent.getResourceAsStream(jarPrefix + "/META-INF/MANIFEST.MF")) {
475473
if (is != null) {

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/inference/trainedmodel/PredictionFieldType.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,7 @@ public String toString() {
4646
return name().toLowerCase(Locale.ROOT);
4747
}
4848

49-
@SuppressForbidden(
50-
reason = "TODO Deprecate any lenient usage of Boolean#parseBoolean https://github.com/elastic/elasticsearch/issues/128993"
51-
)
49+
@SuppressForbidden(reason = "accept lenient boolean field values")
5250
public Object transformPredictedValue(Double value, String stringRep) {
5351
if (value == null) {
5452
return null;

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/type/EsqlDataTypeConverter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -601,7 +601,7 @@ public static BytesRef numericBooleanToString(Object field) {
601601
}
602602

603603
@SuppressForbidden(
604-
reason = "TODO Deprecate any lenient usage of Boolean#parseBoolean https://github.com/elastic/elasticsearch/issues/128993"
604+
reason = "https://www.elastic.co/docs/reference/query-languages/esql/functions-operators/type-conversion-functions#esql-to_boolean"
605605
)
606606
public static boolean stringToBoolean(String field) {
607607
return Boolean.parseBoolean(field);

0 commit comments

Comments
 (0)