Add Boolean.valueOf to forbidden-apis

Author: kvanerum

build-tools-internal/src/main/resources/forbidden/es-all-signatures.txt

@@ -36,6 +36,7 @@ java.nio.channels.SocketChannel#connect(java.net.SocketAddress)
 @defaultMessage use org.elasticsearch.core.Booleans#parseBoolean(java.lang.String)
 java.lang.Boolean#getBoolean(java.lang.String)
 java.lang.Boolean#parseBoolean(java.lang.String)
+java.lang.Boolean#valueOf(java.lang.String)
 
 org.apache.lucene.util.IOUtils @ use @org.elasticsearch.core.internal.io instead
 

libs/native/src/main/java/org/elasticsearch/nativeaccess/PosixNativeAccess.java

@@ -220,6 +220,9 @@ static boolean isMacOrLinuxAarch64() {
     /** -Dorg.elasticsearch.nativeaccess.enableVectorLibrary=false to disable.*/
     static final String ENABLE_JDK_VECTOR_LIBRARY = "org.elasticsearch.nativeaccess.enableVectorLibrary";
 
+    @SuppressForbidden(
+        reason = "TODO Deprecate any lenient usage of Boolean#parseBoolean https://github.com/elastic/elasticsearch/issues/128993"
+    )
     static boolean checkEnableSystemProperty() {
         return Optional.ofNullable(System.getProperty(ENABLE_JDK_VECTOR_LIBRARY)).map(Boolean::valueOf).orElse(Boolean.TRUE);
     }

modules/lang-mustache/src/main/java/org/elasticsearch/script/mustache/MustacheScriptEngine.java

@@ -21,6 +21,7 @@
 import org.elasticsearch.common.text.SizeLimitingStringWriter;
 import org.elasticsearch.common.unit.ByteSizeValue;
 import org.elasticsearch.common.unit.MemorySizeValue;
+import org.elasticsearch.core.SuppressForbidden;
 import org.elasticsearch.script.GeneralScriptException;
 import org.elasticsearch.script.Script;
 import org.elasticsearch.script.ScriptContext;
@@ -96,6 +97,9 @@ public Set<ScriptContext<?>> getSupportedContexts() {
         return Set.of(TemplateScript.CONTEXT, TemplateScript.INGEST_CONTEXT);
     }
 
+    @SuppressForbidden(
+        reason = "TODO Deprecate any lenient usage of Boolean#parseBoolean https://github.com/elastic/elasticsearch/issues/128993"
+    )
     private static CustomMustacheFactory createMustacheFactory(Map<String, String> options) {
         CustomMustacheFactory.Builder builder = CustomMustacheFactory.builder();
         if (options == null || options.isEmpty()) {

server/src/main/java/org/elasticsearch/indices/analysis/wrappers/SettingsInvocationHandler.java

@@ -12,6 +12,7 @@
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
 import org.elasticsearch.common.settings.Settings;
+import org.elasticsearch.core.SuppressForbidden;
 import org.elasticsearch.env.Environment;
 import org.elasticsearch.plugin.settings.BooleanSetting;
 import org.elasticsearch.plugin.settings.IntSetting;
@@ -46,6 +47,9 @@ public static <T> T create(Settings settings, Class<T> parameterType, Environmen
         );
     }
 
+    @SuppressForbidden(
+        reason = "TODO Deprecate any lenient usage of Boolean#parseBoolean https://github.com/elastic/elasticsearch/issues/128993"
+    )
     @Override
     public Object invoke(Object proxy, Method method, Object[] args) throws Throwable {
         assert method.getAnnotations().length == 1;

server/src/test/java/org/elasticsearch/index/mapper/CompletionFieldMapperTests.java

@@ -32,6 +32,7 @@
 import org.elasticsearch.common.lucene.Lucene;
 import org.elasticsearch.common.unit.Fuzziness;
 import org.elasticsearch.common.util.BigArrays;
+import org.elasticsearch.core.Booleans;
 import org.elasticsearch.core.CheckedConsumer;
 import org.elasticsearch.index.IndexSettings;
 import org.elasticsearch.index.IndexVersions;
@@ -242,8 +243,8 @@ public void testTypeParsing() throws Exception {
         Map<String, Object> configMap = (Map<String, Object>) serializedMap.get("field");
         assertThat(configMap.get("analyzer").toString(), is("simple"));
         assertThat(configMap.get("search_analyzer").toString(), is("standard"));
-        assertThat(Boolean.valueOf(configMap.get("preserve_separators").toString()), is(false));
-        assertThat(Boolean.valueOf(configMap.get("preserve_position_increments").toString()), is(true));
+        assertThat(Booleans.parseBoolean(configMap.get("preserve_separators").toString()), is(false));
+        assertThat(Booleans.parseBoolean(configMap.get("preserve_position_increments").toString()), is(true));
         assertThat(Integer.valueOf(configMap.get("max_input_length").toString()), is(14));
     }
 

x-pack/plugin/esql/src/internalClusterTest/java/org/elasticsearch/xpack/esql/action/EsqlQueryLogIT.java

@@ -17,6 +17,7 @@
 import org.elasticsearch.common.logging.ESLogMessage;
 import org.elasticsearch.common.logging.Loggers;
 import org.elasticsearch.common.settings.Settings;
+import org.elasticsearch.core.Booleans;
 import org.elasticsearch.core.TimeValue;
 import org.elasticsearch.xpack.esql.MockAppender;
 import org.elasticsearch.xpack.esql.VerificationException;
@@ -195,7 +196,7 @@ private static void testAllLevels(
                     assertThat(msg.get(ELASTICSEARCH_QUERYLOG_QUERY), is(query));
                     assertThat(appender.getLastEventAndReset().getLevel(), equalTo(logLevel.getKey()));
 
-                    boolean success = Boolean.valueOf(msg.get(ELASTICSEARCH_QUERYLOG_SUCCESS));
+                    boolean success = Booleans.parseBoolean(msg.get(ELASTICSEARCH_QUERYLOG_SUCCESS));
                     assertThat(success, is(expectedException == null));
                     if (expectedErrorMsg == null) {
                         assertThat(msg.get(ELASTICSEARCH_QUERYLOG_ERROR_MESSAGE), is(nullValue()));

x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authc/jwt/JwtRealmSettingsTests.java

@@ -10,6 +10,7 @@
 import org.elasticsearch.common.settings.SecureString;
 import org.elasticsearch.common.settings.Setting;
 import org.elasticsearch.common.settings.Settings;
+import org.elasticsearch.core.Booleans;
 import org.elasticsearch.core.Strings;
 import org.elasticsearch.core.TimeValue;
 import org.elasticsearch.xpack.core.security.authc.RealmConfig;
@@ -233,7 +234,7 @@ public void testPopulateUserMetadata() {
             final Settings settings = Settings.builder().put(settingKey, acceptedValue).build();
             final RealmConfig realmConfig = buildRealmConfig(JwtRealmSettings.TYPE, realmName, settings, 0);
             final Boolean actualValue = realmConfig.getSetting(setting);
-            assertThat(actualValue, equalTo(Boolean.valueOf(acceptedValue)));
+            assertThat(actualValue, equalTo(Booleans.parseBoolean(acceptedValue)));
         }
     }
 

x-pack/plugin/sql/jdbc/src/main/java/org/elasticsearch/xpack/sql/jdbc/TypeConverter.java

@@ -6,6 +6,7 @@
  */
 package org.elasticsearch.xpack.sql.jdbc;
 
+import org.elasticsearch.xpack.sql.client.SuppressForbidden;
 import org.elasticsearch.xpack.sql.proto.StringUtils;
 
 import java.math.BigDecimal;
@@ -310,6 +311,9 @@ private static <T> T failConversion(Object value, EsType columnType, String type
         throw e != null ? new SQLException(message, e) : new SQLException(message);
     }
 
+    @SuppressForbidden(
+        reason = "TODO Deprecate any lenient usage of Boolean#parseBoolean https://github.com/elastic/elasticsearch/issues/128993"
+    )
     private static Boolean asBoolean(Object val, EsType columnType, String typeString) throws SQLException {
         switch (columnType) {
             case BOOLEAN:

x-pack/plugin/watcher/src/main/java/org/elasticsearch/xpack/watcher/notification/email/attachment/ReportingAttachmentParser.java

@@ -18,6 +18,7 @@
 import org.elasticsearch.common.util.set.Sets;
 import org.elasticsearch.common.xcontent.LoggingDeprecationHandler;
 import org.elasticsearch.common.xcontent.XContentHelper;
+import org.elasticsearch.core.SuppressForbidden;
 import org.elasticsearch.core.TimeValue;
 import org.elasticsearch.xcontent.ObjectParser;
 import org.elasticsearch.xcontent.ParseField;
@@ -251,7 +252,7 @@ public Attachment toAttachment(WatchExecutionContext context, Payload payload, R
                     WARNINGS.forEach((warningKey, defaultWarning) -> {
                         String[] text = response.header(warningKey);
                         if (text != null && text.length > 0) {
-                            if (Boolean.valueOf(text[0])) {
+                            if (parseBoolean(text[0])) {
                                 String warning = String.format(Locale.ROOT, defaultWarning, attachment.id());
                                 String customWarning = customWarnings.get(warningKey);
                                 if (Strings.isNullOrEmpty(customWarning) == false) {
@@ -296,6 +297,13 @@ public Attachment toAttachment(WatchExecutionContext context, Payload payload, R
         );
     }
 
+    @SuppressForbidden(
+        reason = "TODO Deprecate any lenient usage of Boolean#parseBoolean https://github.com/elastic/elasticsearch/issues/128993"
+    )
+    private static boolean parseBoolean(String s) {
+        return Boolean.valueOf(s);
+    }
+
     private static void sleep(long sleepMillis, WatchExecutionContext context, ReportingAttachment attachment) {
         try {
             Thread.sleep(sleepMillis);