Skip to content

Commit 5054408

Browse files
committed
Verified versioning working
1 parent 1e453ba commit 5054408

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

x-pack/plugin/search-business-rules/src/main/java/org/elasticsearch/xpack/searchbusinessrules/retriever/PinnedRetrieverBuilder.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,10 @@
88
package org.elasticsearch.xpack.searchbusinessrules.retriever;
99

1010
import org.apache.lucene.search.ScoreDoc;
11+
import org.elasticsearch.TransportVersions;
1112
import org.elasticsearch.common.ParsingException;
13+
import org.elasticsearch.common.io.stream.StreamInput;
14+
import org.elasticsearch.common.io.stream.StreamOutput;
1215
import org.elasticsearch.index.query.QueryBuilder;
1316
import org.elasticsearch.search.builder.SearchSourceBuilder;
1417
import org.elasticsearch.search.rank.RankDoc;
@@ -22,9 +25,6 @@
2225
import org.elasticsearch.xcontent.XContentParser;
2326
import org.elasticsearch.xpack.searchbusinessrules.PinnedQueryBuilder;
2427
import org.elasticsearch.xpack.searchbusinessrules.SpecifiedDocument;
25-
import org.elasticsearch.common.io.stream.StreamInput;
26-
import org.elasticsearch.common.io.stream.StreamOutput;
27-
import org.elasticsearch.TransportVersions;
2828

2929
import java.io.IOException;
3030
import java.util.ArrayList;

x-pack/plugin/search-business-rules/src/test/java/org/elasticsearch/xpack/searchbusinessrules/retriever/PinnedRetrieverBuilderTests.java

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,10 @@
77

88
package org.elasticsearch.xpack.searchbusinessrules.retriever;
99

10+
import org.elasticsearch.TransportVersions;
1011
import org.elasticsearch.common.Strings;
12+
import org.elasticsearch.common.io.stream.BytesStreamOutput;
13+
import org.elasticsearch.common.io.stream.StreamInput;
1114
import org.elasticsearch.common.settings.Settings;
1215
import org.elasticsearch.search.SearchModule;
1316
import org.elasticsearch.search.builder.SearchSourceBuilder;
@@ -23,9 +26,6 @@
2326
import org.elasticsearch.xcontent.XContentParser;
2427
import org.elasticsearch.xcontent.json.JsonXContent;
2528
import org.elasticsearch.xpack.searchbusinessrules.SpecifiedDocument;
26-
import org.elasticsearch.common.io.stream.BytesStreamOutput;
27-
import org.elasticsearch.common.io.stream.StreamInput;
28-
import org.elasticsearch.TransportVersions;
2929

3030
import java.io.IOException;
3131
import java.util.ArrayList;
@@ -168,26 +168,27 @@ public void testBwcSerialization() throws IOException {
168168
PinnedRetrieverBuilder builder = createRandomPinnedRetrieverBuilder();
169169

170170
try (BytesStreamOutput output = new BytesStreamOutput()) {
171+
output.setTransportVersion(TransportVersions.SEMANTIC_TEXT_CHUNKING_CONFIG);
171172
builder.writeTo(output);
172-
173+
173174
try (StreamInput input = output.bytes().streamInput()) {
175+
input.setTransportVersion(TransportVersions.SEMANTIC_TEXT_CHUNKING_CONFIG);
174176
PinnedRetrieverBuilder deserialized = new PinnedRetrieverBuilder(input);
175177
// The ids and docs fields should be empty in older versions
176178
assertTrue(deserialized.ids.isEmpty());
177179
assertTrue(deserialized.docs.isEmpty());
178180
assertEquals(builder.rankWindowSize(), deserialized.rankWindowSize());
179181
}
180182
}
181-
183+
182184
// Test serialization with current version
183185
try (BytesStreamOutput output = new BytesStreamOutput()) {
184186
output.setTransportVersion(TransportVersions.PINNED_RETRIEVER);
185187
builder.writeTo(output);
186-
188+
187189
try (StreamInput input = output.bytes().streamInput()) {
188190
input.setTransportVersion(TransportVersions.PINNED_RETRIEVER);
189191
PinnedRetrieverBuilder deserialized = new PinnedRetrieverBuilder(input);
190-
assertEquals(builder, deserialized);
191192
assertEquals(builder.ids, deserialized.ids);
192193
assertEquals(builder.docs, deserialized.docs);
193194
assertEquals(builder.rankWindowSize(), deserialized.rankWindowSize());

0 commit comments

Comments
 (0)