Remove date_period as offset/scale and constant fold time durations during query planning

Author: timgrein

docs/reference/query-languages/esql/_snippets/functions/types/decay.md

@@ -23,8 +23,6 @@
 
 import java.time.ZoneId;
 import java.time.ZonedDateTime;
-import java.time.temporal.ChronoUnit;
-import java.time.temporal.TemporalAmount;
 
 import static com.carrotsearch.hppc.BitMixer.mix32;
 
@@ -287,8 +285,4 @@ public double decayDateGauss(ZonedDateTime docValueDate) {
         }
     }
 
-    private static long temporalAmountToMillis(TemporalAmount temporalAmount) {
-        return temporalAmount.get(ChronoUnit.SECONDS) * 1_000 + temporalAmount.get(ChronoUnit.NANOS) / 1_000_000;
-    }
-
 }

docs/reference/query-languages/esql/kibana/definition/functions/decay.json

@@ -504,6 +504,10 @@ public static boolean isDateTime(DataType type) {
         return type == DATETIME;
     }
 
+    public static boolean isTimeDuration(DataType t) {
+        return t == TIME_DURATION;
+    }
+
     public static boolean isNullOrTimeDuration(DataType t) {
         return t == TIME_DURATION || isNull(t);
     }
@@ -563,7 +567,15 @@ public static boolean isCounter(DataType t) {
     }
 
     public static boolean isSpatialPoint(DataType t) {
-        return t == GEO_POINT || t == CARTESIAN_POINT;
+        return isGeoPoint(t) || isCartesianPoint(t);
+    }
+
+    public static boolean isGeoPoint(DataType t) {
+        return t == GEO_POINT;
+    }
+
+    public static boolean isCartesianPoint(DataType t) {
+        return t == CARTESIAN_POINT;
     }
 
     public static boolean isSpatialShape(DataType t) {

server/src/main/java/org/elasticsearch/script/ScoreScriptUtils.java

@@ -142,6 +142,37 @@ public String toString() {
 
     private static final String CONSTANT_DOUBLE_NAME = "ConstantDouble";
 
+    public static ExpressionEvaluator.Factory LongFactory(long value) {
+        return new ExpressionEvaluator.Factory() {
+            @Override
+            public ExpressionEvaluator get(DriverContext driverContext) {
+                return new ExpressionEvaluator() {
+                    @Override
+                    public Block eval(Page page) {
+                        return driverContext.blockFactory().newConstantLongBlockWith(value, page.getPositionCount());
+                    }
+
+                    @Override
+                    public void close() {
+
+                    }
+
+                    @Override
+                    public String toString() {
+                        return CONSTANT_LONG_NAME + "[" + value + "]";
+                    }
+                };
+            }
+
+            @Override
+            public String toString() {
+                return CONSTANT_LONG_NAME + "[" + value + "]";
+            }
+        };
+    }
+
+    private static final String CONSTANT_LONG_NAME = "ConstantLong";
+
     public static ExpressionEvaluator.Factory BytesRefFactory(org.apache.lucene.util.BytesRef value) {
         return new ExpressionEvaluator.Factory() {
             @Override

x-pack/plugin/esql-core/src/main/java/org/elasticsearch/xpack/esql/core/type/DataType.java

@@ -145,8 +145,8 @@ decay_result:double
 
 datetimeLinear1
 
-ROW value = TO_DATETIME("2023-01-01T00:00:00Z"), origin = TO_DATETIME("2023-01-01T00:00:00Z"), scale = "24 hours"
-| EVAL decay_result = decay(value, origin, scale, "0 seconds", 0.5, "linear") 
+ROW value = TO_DATETIME("2023-01-01T00:00:00Z"), origin = TO_DATETIME("2023-01-01T00:00:00Z")
+| EVAL decay_result = decay(value, origin, 24 hours, 0 seconds, 0.5, "linear") 
 | KEEP decay_result;
 
 decay_result:double
@@ -155,8 +155,8 @@ decay_result:double
 
 datetimeLinear2
 
-ROW value = TO_DATETIME("2023-01-01T12:00:00Z"), origin = TO_DATETIME("2023-01-01T00:00:00Z"), scale = "24 hours"
-| EVAL decay_result = decay(value, origin, scale, "0 seconds", 0.5, "linear") 
+ROW value = TO_DATETIME("2023-01-01T12:00:00Z"), origin = TO_DATETIME("2023-01-01T00:00:00Z")
+| EVAL decay_result = decay(value, origin, 24 hours, 0 seconds, 0.5, "linear") 
 | KEEP decay_result;
 
 decay_result:double
@@ -165,8 +165,8 @@ decay_result:double
 
 dateNanosLinear1
 
-ROW value = TO_DATE_NANOS("2023-01-01T00:00:00Z"), origin = TO_DATE_NANOS("2023-01-01T00:00:00Z"), scale = "24 hours"
-| EVAL decay_result = decay(value, origin, scale, "0 seconds", 0.5, "linear") 
+ROW value = TO_DATE_NANOS("2023-01-01T00:00:00Z"), origin = TO_DATE_NANOS("2023-01-01T00:00:00Z")
+| EVAL decay_result = decay(value, origin, 24 hours, 0 seconds, 0.5, "linear") 
 | KEEP decay_result;
 
 decay_result:double
@@ -175,8 +175,8 @@ decay_result:double
 
 dateNanosLinear2
 
-ROW value = TO_DATE_NANOS("2023-01-01T12:00:00Z"), origin = TO_DATE_NANOS("2023-01-01T00:00:00Z"), scale = "24 hours"
-| EVAL decay_result = decay(value, origin, scale, "0 seconds", 0.5, "linear") 
+ROW value = TO_DATE_NANOS("2023-01-01T12:00:00Z"), origin = TO_DATE_NANOS("2023-01-01T00:00:00Z")
+| EVAL decay_result = decay(value, origin, 24 hours, 0 seconds, 0.5, "linear") 
 | KEEP decay_result;
 
 decay_result:double