Reintroduce non-semantic version in NodeInfo (revert #102636) #105641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kibana has updated its codebase to handle non-semver (elastic/kibana#172093), so we can now safely reintroduce our change.
ldematte
added
:Core/Infra/Core
Contributor
Author
|
Obsolete |
Contributor
Author
|
Turns out this is not obsolete at all, let me update this |
elasticsearchmachine
added
the
serverless-linked
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
This was referenced Oct 21, 2025
ldematte
added a commit
that referenced
this pull request
Oct 28, 2025
…#137199) When I resumed work on #105641 (now #136853), I had some serverless tests failures. When we moved away from Version in ESRestTest, we added fallbacks for non-sematic versions, which applied the concept "not a semantic version? We assume everything is "current" and supported", which played well for e.g. serverless. Down the road we acquired the concept of "version features", but we lost this concept; now tests with e.g. skip: gte_v720 are failing on serverless because it does not have a "7.2.0" node (*) This PR fixes the problem by re-introducing the non-semver == current version equivalency via a version features predicate. (*) after applying #136853
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 28, 2025
Replaces #105641
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-introduce the change in #100746 and reverted in #102636
The changed caused issue in Kibana with serverless. Kibana has now updated its codebase to handle non-semver (elastic/kibana#172093), so this can go in safely now.