Bump version ids on a new release #105657
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecoop
force-pushed
the
bump-release-version-ids
branch
from
94dcfe3 to
8086265
Compare
rjernst
reviewed
Feb 3, 2025
| return Optional.of(versionJava); | ||
| } | ||
|
|
||
| private static final int VERSION_ADDITION = 1000; |
Member
There was a problem hiding this comment.
This won't be correct for bugfix version, right? It would need to be a patch?
| static Optional<CompilationUnit> addVersionId(CompilationUnit java, Version releaseVersion) { | ||
| TypeDeclaration<?> type = java.getType(0); | ||
|
|
||
| String newVersionField = "RELEASE_" + releaseVersion.toString().replace('.', '_'); |
Member
There was a problem hiding this comment.
This name doesn't seem appropriate. It might end up being the release version, but other versions might be added before release. Could we instead name it something like "INITIAL_WHATEVER"? The version collapsing can then rename the constant as appropriate for what is actually released.
| writeOutNewContents(transportVersionJava, modifiedTv.get()); | ||
| } | ||
|
|
||
| Path indexVersionJava = rootDir.resolve(INDEX_VERSIONS_FILE_PATH); |
Member
There was a problem hiding this comment.
I thought we were only going to bump transport versions on release?
Member
Author
|
This is an old PR, and somewhat out of date - it's an outline of what is needed, but more work is required to update it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to bump transport and index version ids on a new release, controlled by the build automation
Relates #105295