ESQL: Load csv data as ClassRule in single/multi-node #105702
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik9000
reviewed
Feb 21, 2024
Member
There was a problem hiding this comment.
Can you extend the Cluster rule we already have? Or include it as a member or something?
Contributor
Author
There was a problem hiding this comment.
Thanks Nik, I planned to move some things around and clean that up - I'll try your suggestion as part of that!
This avoids running a setup method before each and every test case, which also obscures any errors happening during csv loading.
alex-spies
force-pushed
the
load-esql-csv-data-as-classrule
branch
from
7597710 to
1432c79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the EsqlSpecTestCase tries to upload the CSVs before each and every test run. If an index already exists, a test case will treat the upload as successful and just run.
This is bad if the upload fails, as most tests will fail and we get spammed with cryptic, unrelated error messages.
Avoid running an setup/upload method before each and every test case, instead perform a single setup method as a ClassRule.
Covers only the
single-nodeandmulti-nodetest suites, so far.