Skip to content

Generated code fixes #107658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Generated code fixes #107658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9c88508
Make generated code relative
lauploix Apr 15, 2024
de37454
Adding generated directories to list of ignored repos
lauploix Apr 16, 2024
16ead2e
Create 107658.yaml
lauploix Apr 22, 2024
a1b1329
Update 107658.yaml
lauploix Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,3 +69,5 @@ testfixtures_shared/
# Generated
checkstyle_ide.xml
x-pack/plugin/esql/gen/
/x-pack/plugin/esql/compute/src/main/generated
/x-pack/plugin/esql/src/main/java/generated
5 changes: 5 additions & 0 deletions docs/changelog/107658.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 105660
summary: "Ignore generated code in git"
area: Delivery/Build
type: enhancement
issues: []
2 changes: 1 addition & 1 deletion x-pack/plugin/esql/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ dependencies {
* them and *then* compile them.
*/
tasks.named("compileJava").configure {
options.compilerArgs.addAll(["-s", "${projectDir}/src/main/java/generated"])
options.generatedSourceOutputDirectory = file("src/main/java/generated")
}

tasks.named("javadoc").configure {
Expand Down
3 changes: 2 additions & 1 deletion x-pack/plugin/esql/compute/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,9 @@ dependencies {
testImplementation(project(xpackModule('ql')))
}


tasks.named("compileJava").configure {
options.compilerArgs.addAll(["-s", "${projectDir}/src/main/generated"])
options.generatedSourceOutputDirectory = file("src/main/generated")
}

tasks.named('checkstyleMain').configure {
Expand Down
127 changes: 0 additions & 127 deletions ...nerated/org/elasticsearch/compute/aggregation/CountDistinctBooleanAggregatorFunction.java
View file
Open in desktop

This file was deleted.

39 changes: 0 additions & 39 deletions ...org/elasticsearch/compute/aggregation/CountDistinctBooleanAggregatorFunctionSupplier.java
View file
Open in desktop

This file was deleted.

Loading