Skip to content

[Docs][8.16] Link to ECK Azure snapshot docs #111586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2024
Merged

[Docs][8.16] Link to ECK Azure snapshot docs #111586

merged 1 commit into from
Nov 14, 2024

Conversation

leemthompo
Copy link
Contributor

@leemthompo leemthompo commented Aug 5, 2024 •
edited
Loading

@leemthompo leemthompo added >docs General docs changes v8.16.0 labels Aug 5, 2024
@leemthompo leemthompo requested a review from DaveCTurner August 5, 2024 12:23
@leemthompo leemthompo self-assigned this Aug 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2024

Documentation preview:

@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Aug 5, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

DaveCTurner
DaveCTurner approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy when you know how :) LGTM

@DaveCTurner DaveCTurner added the :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs label Aug 5, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@elasticsearchmachine elasticsearchmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Aug 5, 2024
DaveCTurner
DaveCTurner reviewed Aug 5, 2024
View reviewed changes
docs/reference/snapshot-restore/repository-azure.asciidoc
When running {es} in
https://azure.microsoft.com/en-gb/products/kubernetes-service[Azure Kubernetes
Service], for instance using {eck-ref}[{eck}], you should use
Service], for instance using {eck-ref}/k8s-snapshots.html#k8s-azure-workload-identity[{eck}], you should use
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm that's not linking to the right subsection tho, elastic/cloud-on-k8s#7980 removed k8s-basic-snapshot-azure.

@leemthompo
Copy link
Contributor Author

@DaveCTurner I think best option is to wait for that ECK doc to be available on current in live docs and then re-run CI on this one and merge it. Once confirmed when that switchover should happen, I'll set a reminder.

@leemthompo leemthompo marked this pull request as draft August 5, 2024 14:07
@leemthompo leemthompo changed the title [Docs] Link to ECK Azure snapshot docs [Docs][8.16] Link to ECK Azure snapshot docs Aug 7, 2024
@leemthompo
Copy link
Contributor Author

run docs-build

@leemthompo leemthompo added v8.16.0 auto-backport Automatically create backport pull requests when merged labels Nov 12, 2024
@leemthompo
Copy link
Contributor Author

run docs-build

@leemthompo leemthompo marked this pull request as ready for review November 14, 2024 16:48
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

@elasticsearchmachine elasticsearchmachine added the Team:Distributed Coordination Meta label for Distributed Coordination team label Nov 14, 2024
@leemthompo leemthompo merged commit a193fc3 into main Nov 14, 2024
3 checks passed
@leemthompo leemthompo deleted the leemthompo-patch-2 branch November 14, 2024 17:39
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

The backport operation could not be completed due to the following error:

An unexpected error occurred when attempting to backport this PR.

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 111586

This was referenced Nov 14, 2024
Merged
Merged
@leemthompo
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.x
✅ 8.16

Questions ?

Please refer to the Backport tool documentation

leemthompo added a commit to leemthompo/elasticsearch that referenced this pull request Nov 14, 2024
@leemthompo
[Docs] Link to ECK Azure snapshot docs (elastic#111586)
07f7d86 
(cherry picked from commit a193fc3)
leemthompo added a commit to leemthompo/elasticsearch that referenced this pull request Nov 14, 2024
@leemthompo
[Docs] Link to ECK Azure snapshot docs (elastic#111586)
1d4257b 
(cherry picked from commit a193fc3)
elasticsearchmachine pushed a commit that referenced this pull request Nov 14, 2024
@leemthompo
[Docs] Link to ECK Azure snapshot docs (#111586) (#116836)
c2ad8e4 
(cherry picked from commit a193fc3)
elasticsearchmachine pushed a commit that referenced this pull request Nov 14, 2024
@leemthompo
[Docs] Link to ECK Azure snapshot docs (#111586) (#116835)
e914279 
(cherry picked from commit a193fc3)
salvatore-campagna pushed a commit to salvatore-campagna/elasticsearch that referenced this pull request Nov 18, 2024
@leemthompo @salvatore-campagna
[Docs] Link to ECK Azure snapshot docs (elastic#111586)
1742f51
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this pull request Nov 28, 2024
@leemthompo @alexey-ivanov-es
[Docs] Link to ECK Azure snapshot docs (elastic#111586)
1b695d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaveCTurner DaveCTurner DaveCTurner approved these changes

Assignees

@leemthompo leemthompo

Labels

auto-backport Automatically create backport pull requests when merged backport pending :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >docs General docs changes Team:Distributed Coordination Meta label for Distributed Coordination team Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. Team:Docs Meta label for docs team v8.16.0 v8.17.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@leemthompo @elasticsearchmachine @DaveCTurner @brianseeders @mark-vieira