[ML] Support sparse embedding models in the elasticsearch inference service #112270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkyle
added
>enhancement
:ml
|
Documentation preview: |
|
Pinging @elastic/ml-core (Team:ML) |
|
Hi @davidkyle, I've created a changelog YAML for you. |
davidkyle
commented
Aug 28, 2024
| } | ||
|
|
||
| @Override | ||
| public void start(Model model, ActionListener<Boolean> listener) { |
There was a problem hiding this comment.
These deleted methods were duplicates of the same in the base class BaseElasticsearchInternalService
| } | ||
|
|
||
| @Override | ||
| public void isModelDownloaded(Model model, ActionListener<Boolean> listener) { |
There was a problem hiding this comment.
Duplicate of the base class method
| service.parseRequestConfig(randomInferenceEntityId, taskType, settings, Set.of(), modelListener); | ||
| } | ||
|
|
||
| // Valid model variant |
There was a problem hiding this comment.
These deleted cases were repeated tests
prwhelan
approved these changes
Aug 29, 2024
| createTextExpansionModel(modelId); | ||
| putModelDefinition(modelId, BASE_64_ENCODED_MODEL, RAW_MODEL_SIZE); | ||
| putVocabulary( | ||
| List.of("these", "are", "my", "words", "the", "washing", "machine", "is", "leaking", "octopus", "comforter", "smells"), |
dakrone
pushed a commit
to dakrone/elasticsearch
that referenced
this pull request
Aug 30, 2024
…ervice (elastic#112270) For a sparse embedding model created with the ml trained models APIs
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Sep 4, 2024
…ervice (elastic#112270) For a sparse embedding model created with the ml trained models APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a sparse embedding model created with the ml trained models APIs