Skip to content

Conversation

weizijun
Copy link
Contributor

Add docs in support of AlibabaCloud AI Search support in the Inference API: #111181

Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team v8.16.0 labels Aug 28, 2024
@weizijun
Copy link
Contributor Author

hi, @davidkyle, this is the PR document of AlibabaCloud AI Search Inference. Can you help review it?

@davidkyle davidkyle added >docs General docs changes :ml Machine learning and removed needs:triage Requires assignment of a team area label labels Aug 28, 2024
@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team Team:ML Meta label for the ML team labels Aug 28, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@davidkyle
Copy link
Member

Thanks @weizijun, I've assigned to @szabosteve who writes the docs

@szabosteve
Copy link
Contributor

@elasticsearchmachine test this please

Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great documentation! Thank you for drafting this! I left a couple of suggestions, mostly nits.

weizijun and others added 10 commits August 28, 2024 22:47
@weizijun
Copy link
Contributor Author

Great documentation! Thank you for drafting this! I left a couple of suggestions, mostly nits.

Sorry for my poor English, I have submitted the changes directly on GitHub, thank you!

@szabosteve
Copy link
Contributor

szabosteve commented Aug 28, 2024

Sorry for my poor English, I have submitted the changes directly on GitHub, thank you!

Your English is fine! Thank you for this huge docs contribution.
I checked the pages out locally and they build fine. I pushed some indentation fixes via c591269. Hope you don't mind.

Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for writing the docs!

@weizijun
Copy link
Contributor Author

I checked the pages out locally and they build fine. I pushed some indentation fixes via c591269. Hope you don't mind.

It doesn't matter, thanks!

@szabosteve
Copy link
Contributor

@elasticsearchmachine test this please

@szabosteve szabosteve merged commit b9dea69 into elastic:main Aug 29, 2024
6 checks passed
dakrone pushed a commit to dakrone/elasticsearch that referenced this pull request Aug 30, 2024
cbuescher pushed a commit to cbuescher/elasticsearch that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team :ml Machine learning Team:Docs Meta label for docs team Team:ML Meta label for the ML team v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants