Update synthetic source documentation #112363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salvatore-campagna
added
>docs
|
Documentation preview: |
elasticsearchmachine
added
Team:Docs
|
Pinging @elastic/es-docs (Team:Docs) |
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
This reverts commit 0895a76.
lkts
approved these changes
Aug 29, 2024
|
This does not fix all of #112351, does it? So it should not be closed. |
|
I will remove the following entries in another PR so that we can backport it easily |
lkts
approved these changes
Oct 17, 2024
| <<copy-to,`copy_to`>> or with <<doc-values,`doc_values`>> disabled. | ||
| default configuration. | ||
|
|
||
| Synthetic source always sorts `boolean` fields. For example: |
There was a problem hiding this comment.
Another note for a follow up is to replace "always sorts" with "may sort" or "does not preserve order" in cases like this.
There was a problem hiding this comment.
Maybe we can have a single page that captures all this.
There was a problem hiding this comment.
I will just say "may change" because usually that statement is followed by an example where the order actually is different. So I think the sentence is relevant to understand the example.
salvatore-campagna
added
auto-backport
salvatore-campagna
added a commit
to salvatore-campagna/elasticsearch
that referenced
this pull request
Oct 18, 2024
* docs: update synthetic source docs * fix: also doc values false works * Revert "fix: also doc values false works" This reverts commit 0895a76. * fix: update synthetic source documentation * fix: all field types support it * fix: no need to explicitly mention it * fix: synthetic source sorting * fix: may instead of might (cherry picked from commit ebd363d)
salvatore-campagna
added a commit
to salvatore-campagna/elasticsearch
that referenced
this pull request
Oct 18, 2024
* docs: update synthetic source docs * fix: also doc values false works * Revert "fix: also doc values false works" This reverts commit 0895a76. * fix: update synthetic source documentation * fix: all field types support it * fix: no need to explicitly mention it * fix: synthetic source sorting * fix: may instead of might (cherry picked from commit ebd363d)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
salvatore-campagna
added a commit
that referenced
this pull request
Oct 18, 2024
salvatore-campagna
added a commit
that referenced
this pull request
Oct 18, 2024
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Oct 25, 2024
* docs: update synthetic source docs * fix: also doc values false works * Revert "fix: also doc values false works" This reverts commit 0895a76. * fix: update synthetic source documentation * fix: all field types support it * fix: no need to explicitly mention it * fix: synthetic source sorting * fix: may instead of might
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
* docs: update synthetic source docs * fix: also doc values false works * Revert "fix: also doc values false works" This reverts commit 0895a76. * fix: update synthetic source documentation * fix: all field types support it * fix: no need to explicitly mention it * fix: synthetic source sorting * fix: may instead of might
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After all synthetic source improvements we introduced, documentation
needs to be updated to reflect the fact that it works for all field types
no matter the values of parameters like
doc_values,storeorignore_malformed.Note that in this PR we only target removing incorrect information.
Better documentation about new functionality will be added as part
of another PR.
Resolves #112351