Skip to content

Conversation

thecoop
Copy link
Member

@thecoop thecoop commented Aug 30, 2024

The Settings method doesn't have permissions to access secured files

@thecoop thecoop added >bug v8.15.1 :Core/Infra/Core Core issues without another label labels Aug 30, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @thecoop, I've created a changelog YAML for you.

@thecoop thecoop marked this pull request as ready for review September 2, 2024 10:31
@thecoop thecoop added auto-backport Automatically create backport pull requests when merged and removed backport labels Sep 2, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Sep 2, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @thecoop, I've created a changelog YAML for you.

@thecoop
Copy link
Member Author

thecoop commented Sep 2, 2024

This fixes the bug - we can look at improving the testing as part of #112411

@thecoop thecoop requested a review from a team September 2, 2024 14:08
@thecoop thecoop added the :Security/Security Security issues without another label label Sep 2, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Security Meta label for security team label Sep 2, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@thecoop thecoop added auto-backport-and-merge blocker and removed auto-backport Automatically create backport pull requests when merged labels Sep 2, 2024
Copy link
Contributor

@mosche mosche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🥇

@navyau09 navyau09 merged commit 2871b94 into elastic:main Sep 3, 2024
15 checks passed
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.15

thecoop added a commit to thecoop/elasticsearch that referenced this pull request Sep 3, 2024
… permissions (elastic#112400)

* Make sure file accesses are done in stack frames with permissions

* Update docs/changelog/112400.yaml

* Delete docs/changelog/112400.yaml

* Update docs/changelog/112400.yaml
elasticsearchmachine pushed a commit that referenced this pull request Sep 3, 2024
… permissions (#112400) (#112441)

* Make sure file accesses are done in stack frames with permissions

* Update docs/changelog/112400.yaml

* Delete docs/changelog/112400.yaml

* Update docs/changelog/112400.yaml
@ppf2
Copy link
Contributor

ppf2 commented Sep 3, 2024

@thecoop I believe this is now targeted for 8.15.2, should we update the version label? Also, should we add a known issue entry to 8.15.0 and 8.15.1 (upcoming) release notes? Thx!

@thecoop
Copy link
Member Author

thecoop commented Sep 4, 2024

Good idea - created #112506

cbuescher pushed a commit to cbuescher/elasticsearch that referenced this pull request Sep 4, 2024
… permissions (elastic#112400)

* Make sure file accesses are done in stack frames with permissions

* Update docs/changelog/112400.yaml

* Delete docs/changelog/112400.yaml

* Update docs/changelog/112400.yaml
gwbrown added a commit to gwbrown/elasticsearch that referenced this pull request Sep 6, 2024
gwbrown added a commit to gwbrown/elasticsearch that referenced this pull request Sep 6, 2024
…ames with permissions (elastic#112400)"

This reverts commit c85ca4c046f843858590072423521ec27d17b357.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>bug :Core/Infra/Core Core issues without another label :Security/Security Security issues without another label Team:Core/Infra Meta label for core/infra team Team:Security Meta label for security team v8.15.2 v8.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants