Skip to content

[8.15] Make sure file accesses in DnRoleMapper are done in stack frames with permissions (#112400) #112441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2024
+8 −1
Merged

[8.15] Make sure file accesses in DnRoleMapper are done in stack frames with permissions (#112400) #112441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/112400.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 112400
summary: Make sure file accesses in `DnRoleMapper` are done in stack frames with permissions
area: Infra/Core
type: bug
issues: []
4 changes: 3 additions & 1 deletion ...n/security/src/main/java/org/elasticsearch/xpack/security/authc/support/DnRoleMapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,9 @@ public static Map<String, List<String>> parseFile(Path path, Logger logger, Stri
}

try {
Settings settings = Settings.builder().loadFromPath(path).build();
// create this here so it's in an allowed stack frame
var file = Files.newInputStream(path);
Settings settings = Settings.builder().loadFromStream(path.getFileName().toString(), file, false).build();

Map<DN, Set<String>> dnToRoles = new HashMap<>();
Set<String> roles = settings.names();
Expand Down