Skip to content

[DOCS] Fix User agent processor properties #112518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2024
Merged

[DOCS] Fix User agent processor properties #112518

merged 1 commit into from
Oct 15, 2024

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Sep 4, 2024

As far as I can tell, the properties are defined here:

elasticsearch/modules/ingest-user-agent/src/main/java/org/elasticsearch/ingest/useragent/UserAgentProcessor.java

Lines 253 to 259 in a36d90c

enum Property {
NAME,
OS,
DEVICE,
ORIGINAL,
VERSION;

@pquentin pquentin added >docs General docs changes :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP Team:Data Management Meta label for data/management team auto-backport-and-merge v8.16.0 v8.14.4 v8.15.2 labels Sep 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Documentation preview:

@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Sep 4, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@pquentin pquentin mentioned this pull request Sep 4, 2024
Merged
@mark-vieira mark-vieira added auto-backport Automatically create backport pull requests when merged and removed auto-backport-and-merge labels Oct 4, 2024
joegallo
joegallo approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@joegallo joegallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this looks like the implied docs changed that should have come along with #37984 / #37727. Good catch!

@pquentin pquentin merged commit fc23f2f into elastic:main Oct 15, 2024
6 checks passed
This was referenced Oct 15, 2024
Merged
Merged
pquentin added a commit to pquentin/elasticsearch that referenced this pull request Oct 15, 2024
@pquentin
[DOCS] Fix User agent processor properties (elastic#112518)
3f78376
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.14
✅ 8.15

pquentin added a commit to pquentin/elasticsearch that referenced this pull request Oct 15, 2024
@pquentin
[DOCS] Fix User agent processor properties (elastic#112518)
6235519
elasticsearchmachine pushed a commit that referenced this pull request Oct 15, 2024
@pquentin
[DOCS] Fix User agent processor properties (#112518) (#114835)
54a220a
elasticsearchmachine pushed a commit that referenced this pull request Oct 15, 2024
@pquentin
[DOCS] Fix User agent processor properties (#112518) (#114834)
6c30c6c
kderusso pushed a commit to kderusso/elasticsearch that referenced this pull request Oct 15, 2024
@pquentin @kderusso
[DOCS] Fix User agent processor properties (elastic#112518)
ba8b6ce
@pquentin pquentin removed the v8.16.0 label Oct 16, 2024
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Oct 25, 2024
@pquentin @georgewallace
[DOCS] Fix User agent processor properties (elastic#112518)
4ea5970
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joegallo joegallo joegallo approved these changes

Assignees
No one assigned
Labels
auto-backport Automatically create backport pull requests when merged :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >docs General docs changes Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v8.14.4 v8.15.4 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pquentin @elasticsearchmachine @joegallo @mark-vieira