Skip to content

Conversation

thecoop
Copy link
Member

@thecoop thecoop commented Sep 4, 2024

Backport #110222 to 8.15

JDK 23 removes the COMPAT locale provider, leaving CLDR as the only option. This commit configures Elasticsearch
to use the CLDR provider when on JDK 23, but still use the existing COMPAT provider when on JDK 22 and below.

This causes some differences in locale behaviour; this also adapts various tests to still work whether run on COMPAT or CLDR.
@thecoop thecoop added :Core/Infra/Core Core issues without another label >refactoring backport v8.15.2 labels Sep 4, 2024
@thecoop thecoop requested review from a team as code owners September 4, 2024 14:54
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Documentation preview:

@thecoop
Copy link
Member Author

thecoop commented Sep 5, 2024

@elasticmachine update branch

@thecoop thecoop changed the title Backport CLDR locale support to 8.15 [8.15] Use CLDR locale provider on JDK 23 (#112544) Sep 5, 2024
@thecoop thecoop added the Team:Core/Infra Meta label for core/infra team label Sep 6, 2024
@thecoop thecoop merged commit 103f4ee into elastic:8.15 Sep 6, 2024
15 checks passed
@thecoop thecoop deleted the 8.15-cldr-locales branch September 6, 2024 12:50
@mark-vieira
Copy link
Contributor

@thecoop @rjernst although we don't intend to bump the bundled JDK on 7.17 do we still intend to support Java 23 there? Does this need to be backported?

@thecoop
Copy link
Member Author

thecoop commented Sep 6, 2024

Yes, as part of the move to CLDR, we give users the option to run 7.17.25+ and 8.15.2+ on a supported version of the JDK once JDK 23 is released, if they want to (and can upgrade without issues)

@mark-vieira
Copy link
Contributor

That would require these changes to be backported to 7.17, yes? Has that been done?

@thecoop
Copy link
Member Author

thecoop commented Sep 6, 2024

See #112544

@mark-vieira
Copy link
Contributor

Missed that. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport :Core/Infra/Core Core issues without another label >refactoring Team:Core/Infra Meta label for core/infra team v8.15.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants