Fix ES|QL hyperbolic functions docs #112562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v8.16.0
needs:triage
jan-elastic
added
>non-issue
:Analytics/ES|QL
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
alex-spies
approved these changes
Sep 6, 2024
...in/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/math/Tanh.java
Outdated
Show resolved
Hide resolved
...gin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/math/Sin.java
Outdated
Show resolved
Hide resolved
|
Slightly related: #112437 |
jan-elastic
force-pushed
the
fix-esql-hyperbolic-fns-docs
branch
from
85f429d to
e6f4b3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For hyperbolic functions "an angle, in radians" makes no sense (radians are a unit of circular angle, which is not applicable for hyperbolic geometry).
See also Wikipedia or the underlying function's JavaDocs.