-
Notifications
You must be signed in to change notification settings - Fork 25.5k
[DOCS] Adds DeBERTA v2 to the tokenizers list in API docs #112752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Documentation preview: |
Pinging @elastic/ml-core (Team:ML) |
Pinging @elastic/es-docs (Team:Docs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks Istvan!
overall, I think that the deberta_v2 tokenizer is usable for any ML task, but it doesn't appear in all of the tasks in https://elasticsearch_bk_112752.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/inference-processor.html#inference-processor-fill-mask-opt
I also noticed that page doesn't have a secontion for text_similarity, which is the main thing we will be using deberta for. I don't think that needs to be a part of this PR, but we should consider adding that.
Co-authored-by: Max Hniebergall <[email protected]>
Hey @maxhniebergall, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just wondering why some of the new sections in docs/reference/ingest/processors/inference.asciidoc have span
and some dont?
edit: I see that zero-shot classification doesn't support span https://github.com/elastic/elasticsearch/blob/main/x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/inference/trainedmodel/ZeroShotClassificationConfig.java#L145
💚 Backport successful
|
…2752) Co-authored-by: Max Hniebergall <[email protected]>
…114203) Co-authored-by: Max Hniebergall <[email protected]>
…2752) Co-authored-by: Max Hniebergall <[email protected]>
Overview
This PR expands the
Tokenization properties
section on the PUT trained models API doc page and the Infer trained model API doc page with the DeBERTa v2 tokenizer reference docs. The updates also effect the Inference processor reference docs.Preview
PUT trained models - Tokenization properties
Infer trained model
Inference processor