-
Notifications
You must be signed in to change notification settings - Fork 25.5k
Multi term intervals: increase max_expansions #112826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi term intervals: increase max_expansions #112826
Conversation
Documentation preview: |
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
@mayya-sharipova I am trying to find the reason for the original limit. What was the reason for the 128? It seems very specific :/. Did we just pick the value at random? |
@benwtrent Thanks for checking.
The limit came as default value from Lucene. Lucene also has warnings: " Setting.. maxExpansions ..to higher than the default value of can be both slow and memory-intensive". But outside of intervals, for our default multi-term queries we support different rewrite params , and allow to rewrite up to |
8535e4c
to
7095cf3
Compare
@mayya-sharipova Ah, it was the default value, not the expressed limit in Lucene. |
07f3b7e
to
ff74c90
Compare
Currently multi term interval queries (prefix, wildcard, fuzzy, regexp and range) can expand maximum to 128 terms. To reach parity with span queries that we want to deprecate, set max expansions to indices.query.bool.max_clause_count which is used in span queries. Relates to elastic#110491
0beed2b
to
e8f8a08
Compare
@elasticsearchmachine update branch |
…s_increase_max_expansions
All tests pass, there is a failure in the test: So I am going to merge in lcuene_snapshot branch this change. |
7150729
into
elastic:lucene_snapshot
Currently multi term interval queries (prefix, wildcard, fuzzy, regexp and range) can expand maximum to 128 terms. To reach parity with span queries that we want to deprecate, set max expansions to indices.query.bool.max_clause_count which is used in span queries. Relates to #110491
Currently multi term interval queries (prefix, wildcard, fuzzy, regexp and range) can
expand maximum to 128 terms. To reach parity with span queries that we want to deprecate,
set max expansions to indices.query.bool.max_clause_count which is used in span queries.
Relates to #110491