Skip to content

[DOCS] Fix a couple of docs typos #112901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2024
Merged

[DOCS] Fix a couple of docs typos #112901

merged 1 commit into from
Sep 20, 2024

Conversation

pionCham
Copy link
Contributor

fix a couple of docs typos

  • nonsignificant to insignificant
  • of all of to of all

@cla-checker-service CLA Checker Service
Copy link

cla-checker-service bot commented Sep 15, 2024 •
edited
Loading

💚 CLA has been signed

@github-actions GitHub Actions
Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.0.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Sep 15, 2024
@pionCham pionCham marked this pull request as draft September 15, 2024 18:48
@pionCham pionCham marked this pull request as ready for review September 15, 2024 18:52
@kingherc kingherc self-assigned this Sep 18, 2024
@kingherc kingherc added the >docs General docs changes label Sep 18, 2024
@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team and removed needs:triage Requires assignment of a team area label labels Sep 18, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@kingherc kingherc added the needs:triage Requires assignment of a team area label label Sep 18, 2024
@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Sep 18, 2024
szabosteve
szabosteve approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@szabosteve
Copy link
Contributor

I think nonsignificant is the better word to use in this context though. Nonsignificant has the meaning of not statistically significant while the meaning of insignificant doesn't have mathematical connotations. I'm not a native speaker though.
@leemthompo What's your opinion?

@pionCham
Copy link
Contributor Author

I think nonsignificant is the better word to use in this context though. Nonsignificant has the meaning of not statistically significant while the meaning of insignificant doesn't have mathematical connotations. I'm not a native speaker though. @leemthompo What's your opinion?

Thanks for pointing out! But in this context Tokens whose weight is less than tokens_weight_threshold are considered nonsignificant and pruned. This value must be between 0 and 1. Default: 0.4 , i think the author does not highlight the salience ，so i'm more inclined to use the word insignificant @szabosteve 😊

@kingherc
Copy link
Contributor

Sounds good, since there's an approval I'm going ahead and merge this. If there are any comments in the future, we can discuss changing the nuances again.

@kingherc kingherc merged commit d68f2fa into elastic:main Sep 20, 2024
8 checks passed
@kingherc kingherc mentioned this pull request Sep 20, 2024
Merged
kingherc pushed a commit to kingherc/elasticsearch that referenced this pull request Sep 20, 2024
@pionCham @kingherc
fix a couple of docs typos (elastic#112901)
cf1d8c5
@kingherc kingherc mentioned this pull request Sep 20, 2024
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.x
✅ 8.15

kingherc pushed a commit to kingherc/elasticsearch that referenced this pull request Sep 20, 2024
@pionCham @kingherc
fix a couple of docs typos (elastic#112901)
b989133
elasticsearchmachine pushed a commit that referenced this pull request Sep 20, 2024
@kingherc @pionCham
fix a couple of docs typos (#112901) (#113283)
6f63a4e 
Co-authored-by: Pm Ching <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Sep 20, 2024
@kingherc @pionCham
fix a couple of docs typos (#112901) (#113284)
6376c57 
Co-authored-by: Pm Ching <[email protected]>
@pionCham pionCham deleted the fix-typos branch September 21, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szabosteve szabosteve szabosteve approved these changes

Assignees

@kingherc kingherc

Labels

>docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v8.15.3 v8.16.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pionCham @elasticsearchmachine @szabosteve @kingherc