Making changes to BulkRequest to enable component template substitutions in the simulate ingest API (#112957) #113067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons in the simulate ingest API (elastic#112957)
masseyke
added
backport
v8.16.0
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of a handful of PRs that will result in the addition of component template substitutions support to the simulate ingest API. See the draft PR at #112762 for the full idea.
This PR adds two methods to the BulkRequest API that will be used by the component template substitution code -- getComponentTemplateSubstitutions() and shallowClone(). Both will be used in a future update to TransportAbstractBulkAction.
The next PR will add the transport changes to take advantage of these changes, and the final one will add the full documentation and rest-level testing (this PR updates RestSimulateIngestAction to pass the new SimulateBulkRequest constructor arg in order to compile, but there is no actual additional functionality at the rest layer).