[Inference API] Deprecate elser service #113216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (Team:ML) |
|
Hi @maxhniebergall, I've created a changelog YAML for you. Note that since this PR is labelled |
davidkyle
reviewed
Sep 20, 2024
There was a problem hiding this comment.
Now that the elasticsearch service can run the elser model can we remove the elser service in this PR? The elasticsearch service can be an alias to the elser service, adding some logic to the InferenceServiceRegistry lookup code would simply return the elasticsearch service when elser is requested.
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
maxhniebergall
force-pushed
the
mergeElserService
branch
from
1c71a45 to
6b8022d
Compare
…it and has aliased it
… ID (with deprecation message)
…n for deprecation
to pass the service name if it is elser or elasticsearch this will allow the elasticsearch service to maintain BWC for null model IDs if the service was elser.
added 6 commits
September 27, 2024 12:59
maxhniebergall
force-pushed
the
mergeElserService
branch
from
4f8b8fb to
ed234c7
Compare
davidkyle
approved these changes
Oct 1, 2024
...ference/src/main/java/org/elasticsearch/xpack/inference/action/TransportInferenceAction.java
Outdated
Show resolved
Hide resolved
davidkyle
reviewed
Oct 1, 2024
...ference/src/main/java/org/elasticsearch/xpack/inference/action/TransportInferenceAction.java
Outdated
Show resolved
Hide resolved
added 2 commits
October 2, 2024 13:43
…erService # Conflicts: # x-pack/plugin/inference/src/internalClusterTest/java/org/elasticsearch/xpack/inference/integration/ModelRegistryIT.java # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/action/TransportPutInferenceModelAction.java # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/elasticsearch/BaseElasticsearchInternalService.java # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/elasticsearch/ElasticsearchInternalService.java # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/elser/ElserInternalService.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/elasticsearch/ElasticsearchInternalServiceTests.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/elser/ElserInternalServiceTests.java
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
matthewabbott
pushed a commit
to matthewabbott/elasticsearch
that referenced
this pull request
Oct 4, 2024
* merging * copy elser service files into elasticsearch service * Add deprecation log message for elser service * improve deprecation warning * change elasticsearch internal service elser case to use elser model * switch elasticsearch elser tests to use elasticsearch elser * Update docs/changelog/113216.yaml * alias elser service to elasticsearch * delete elser service package now that elasticsearch service supports it and has aliased it * Add deprecation warning to infer API for elser * Fix accidentally introduced NPE and retain BWC support for null model ID (with deprecation message) * change "area" to "REST API" because "Machine Learning" isn't an option for deprecation * change elser literals to static variable * change Put and Elasticsearch Internal service to pass the service name if it is elser or elasticsearch this will allow the elasticsearch service to maintain BWC for null model IDs if the service was elser. * fix up tests to match new elasticsearch service semantics regarding elser. * Move passing of service name * add persistence for elser models in elasticsearch * copy elser service files into elasticsearch service * Add deprecation log message for elser service * Add deprecation warning to infer API for elser * fix merge conflicts * fix merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a deprecation warning for the elser service on
PutandInferand copies the elser service files so we can simply delete the elser service after 8.16This change maintains BWC with the elser service.