Add deprecation warnings for week-date specifiers #113247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecoop
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
@elasticmachine rerun elasticsearch-ci/packaging-tests-windows-sample |
rjernst
approved these changes
Sep 20, 2024
| 'ml/evaluate_data_frame/Test outlier_detection auc_roc include curve', | ||
| 'ml/evaluate_data_frame/Test classification auc_roc', | ||
| 'ml/evaluate_data_frame/Test classification auc_roc with default top_classes_field', | ||
| 'security/authz/13_index_datemath/Test indexing documents with datemath, when forbidden', |
There was a problem hiding this comment.
The warnings are causing failures with previous yaml test definitions
thecoop
added
the
auto-backport
|
Windows packaging tests are #113177 |
thecoop
added a commit
to thecoop/elasticsearch
that referenced
this pull request
Sep 20, 2024
Week dates also change on JDK 23, so add a deprecation warning if they are used on COMPAT
💚 Backport successful
|
thecoop
added a commit
that referenced
this pull request
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Week dates are changing on CLDR, so warn about that too.
Follows on from #112917