Skip to content

[ML] Warn for model load failures if they have a status code <500 #113280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 23, 2024
Merged

[ML] Warn for model load failures if they have a status code <500 #113280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b689468
On model load failure, warn if the failure status code was less tahn 500
Sep 20, 2024
8175a0e
Merge branch 'main' of github.com:elastic/elasticsearch
Sep 20, 2024
5105dc7
Update docs/changelog/113280.yaml
maxhniebergall Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/113280.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 113280
summary: Warn for model load failures if they have a status code <500
area: Machine Learning
type: bug
issues: []
7 changes: 6 additions & 1 deletion ...va/org/elasticsearch/xpack/ml/inference/assignment/TrainedModelAssignmentNodeService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import org.elasticsearch.ElasticsearchException;
import org.elasticsearch.ResourceNotFoundException;
import org.elasticsearch.action.ActionListener;
import org.elasticsearch.action.search.SearchPhaseExecutionException;
Expand Down Expand Up @@ -775,7 +776,11 @@ private void updateStoredState(String deploymentId, RoutingInfoUpdate update, Ac
}

private void handleLoadFailure(TrainedModelDeploymentTask task, Exception ex, ActionListener<Boolean> retryListener) {
logger.error(() -> "[" + task.getDeploymentId() + "] model [" + task.getParams().getModelId() + "] failed to load", ex);
if (ex instanceof ElasticsearchException esEx && esEx.status().getStatus() < 500) {
logger.warn(() -> "[" + task.getDeploymentId() + "] model [" + task.getParams().getModelId() + "] failed to load", ex);
} else {
logger.error(() -> "[" + task.getDeploymentId() + "] model [" + task.getParams().getModelId() + "] failed to load", ex);
}
if (task.isStopped()) {
logger.debug(
() -> format(
Expand Down
Loading