Closes #112812 Avoid copying to a non-existent field when dynamic mappings are disabled #113290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
elasticsearchmachine
added
v9.0.0
external-contributor
elasticsearchmachine
added
the
needs:triage
henriquepaes1
changed the title
henriquepaes1
changed the title
gbanasiak
added
the
:Search Foundations/Mapping
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
elasticsearchmachine
added
Team:Search Foundations
|
Hey @gbanasiak! I just wanted to check in on this PR and see if there’s any blocker that I can handle to move it forward to review or if it’s already in the queue. Thanks in advance for your time! |
|
@henriquepaes1 there is no formal process for somebody to get assigned to this. The appropriate team has been pinged, when they have adequate cycles to look, I am sure they will. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #112812 by introducing verification of fields mentioned in copyTo when creating a non-dynamic mapping.
The verification made by the FieldMapper#validate method retrieves the leaf mapper associated with the searched field when the dynamic property of the mapping is explicitly set to false, ensuring that the verification occurs exclusively in non-dynamic contexts without affecting other mappings.