-
Notifications
You must be signed in to change notification settings - Fork 25.5k
[ES|QL] add reverse function #113297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES|QL] add reverse function #113297
Changes from 44 commits
88de8b7
9588aca
5a5c383
590e0e4
2d0b623
5a588fe
19c60ee
6a7bf6b
23bc6ee
03e9c12
67b228f
647902a
bceb604
27716dd
234b795
f1c4694
d900561
2c1bbf4
39f2e1b
ead4a09
0cfde3d
ab49f66
4e0d422
60d670e
364d357
1c0268b
60b36bb
627144c
8f11f09
f5007e7
5bfcd0a
257c9f9
7c0b1aa
fa2fc0b
791d767
11046e4
f644990
a891a08
4b558c9
26d5a3c
de7446f
3160be0
d8e78db
d7b5a28
8ce4406
8cad604
28c8d8b
e21f87f
ad7c68f
6c09607
b512026
247495a
7763155
9041899
43a63e7
9c11030
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
pr: 113297 | ||
summary: "[ES|QL] add reverse function" | ||
area: ES|QL | ||
type: enhancement | ||
issues: [] |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add more complex csv tests. For example:
from employees | sort emp_no | eval jobs_reversed = reverse(job_positions) | keep job*, emp_no | limit 5
which deals with multi-values andnull
sfrom employees | sort emp_no | eval name_reversed = reverse(reverse(first_name)), eq = name_reversed == first_name | keep emp_no, first_name, name_reversed, eq | limit 5
that uses nested function calls.row x = null | eval y = reverse(x)
row x = 1 | eval y = reverse((null + 1)::string)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For csv tests, I forgot we now have
books
index that also hastext
field type (employees
androw
only havekeyword
field types). Please, look into adding couple of tests withbooks
index as well. Thanks.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in the following commits.
627144c
8f11f09
f5007e7