Upgrade to Lucene 9.12.0 #113333
Merged
Upgrade to Lucene 9.12.0 #113333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…torScorerFactoryTests (#109303) This commit adds a couple of missing supported checks to org.elasticsearch.vec.VectorScorerFactoryTests. Without these the test try, and fail, to run on Windows.
Updated LuceneDocument to take advantage of looking up feature values on existing features and selecting the max when parsing multi-value sparse vectors
Just doing the minimal fixes to making this pass tests again and compile. One trivial constructor adjustment and a few adjustments to task count expectations in some tests from having Lucene fork less.
|
Lucene 9.12.0 has been released. This PR is ready of final review. I cannot officially review in GH, but it LGTM. |
|
My only slight concern is the flat vector formats. Now Lucene 9.12 treats them like exposed normal codecs we need to make sure there aren't any weird name conflicts, etc. with our flat formats. I don't think there should be since ours have a different name. Just wanting to be sure. |
javanna
approved these changes
Sep 30, 2024
ChrisHegarty
added
the
auto-backport
ChrisHegarty
added a commit
that referenced
this pull request
Oct 1, 2024
This commit upgrades to Lucene 9.12.0. Co-authored-by: Adrien Grand <[email protected]> Co-authored-by: Armin Braun <[email protected]> Co-authored-by: Benjamin Trent <[email protected]> Co-authored-by: Chris Hegarty <[email protected]> Co-authored-by: John Wagster <[email protected]> Co-authored-by: Luca Cavanna <[email protected]> Co-authored-by: Mayya Sharipova <[email protected]>
ChrisHegarty
removed
backport pending
auto-backport
ChrisHegarty
added a commit
that referenced
this pull request
Oct 1, 2024
This commit upgrades to Lucene 9.12.0. Co-authored-by: Adrien Grand <[email protected]> Co-authored-by: Armin Braun <[email protected]> Co-authored-by: Benjamin Trent <[email protected]> Co-authored-by: John Wagster <[email protected]> Co-authored-by: Luca Cavanna <[email protected]> Co-authored-by: Mayya Sharipova <[email protected]>
matthewabbott
pushed a commit
to matthewabbott/elasticsearch
that referenced
this pull request
Oct 4, 2024
This commit upgrades to Lucene 9.12.0. Co-authored-by: Adrien Grand <[email protected]> Co-authored-by: Armin Braun <[email protected]> Co-authored-by: Benjamin Trent <[email protected]> Co-authored-by: Chris Hegarty <[email protected]> Co-authored-by: John Wagster <[email protected]> Co-authored-by: Luca Cavanna <[email protected]> Co-authored-by: Mayya Sharipova <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 8, 2024
This copies the work from apache/lucene#13651 into Elasticsearch. The main reason for the copy is to simply allow it to be deployed & used in Elasticsearch prior to Elasticsearch upgrading to Lucene 10. At which point, we will then use the format as provided by Lucene. This is currently blocked by two pieces of work: blocked by: #112933 blocked by: #113333 After the format is merged, then code will be added for integration tests & integration with Elasticsearch through new index format types in the API.
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Oct 8, 2024
…ic#113491) This copies the work from apache/lucene#13651 into Elasticsearch. The main reason for the copy is to simply allow it to be deployed & used in Elasticsearch prior to Elasticsearch upgrading to Lucene 10. At which point, we will then use the format as provided by Lucene. This is currently blocked by two pieces of work: blocked by: elastic#112933 blocked by: elastic#113333 After the format is merged, then code will be added for integration tests & integration with Elasticsearch through new index format types in the API.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 8, 2024
…) (#114362) This copies the work from apache/lucene#13651 into Elasticsearch. The main reason for the copy is to simply allow it to be deployed & used in Elasticsearch prior to Elasticsearch upgrading to Lucene 10. At which point, we will then use the format as provided by Lucene. This is currently blocked by two pieces of work: blocked by: #112933 blocked by: #113333 After the format is merged, then code will be added for integration tests & integration with Elasticsearch through new index format types in the API. Co-authored-by: Elastic Machine <[email protected]>
matthewabbott
pushed a commit
to matthewabbott/elasticsearch
that referenced
this pull request
Oct 10, 2024
…ic#113491) This copies the work from apache/lucene#13651 into Elasticsearch. The main reason for the copy is to simply allow it to be deployed & used in Elasticsearch prior to Elasticsearch upgrading to Lucene 10. At which point, we will then use the format as provided by Lucene. This is currently blocked by two pieces of work: blocked by: elastic#112933 blocked by: elastic#113333 After the format is merged, then code will be added for integration tests & integration with Elasticsearch through new index format types in the API.
davidkyle
pushed a commit
to davidkyle/elasticsearch
that referenced
this pull request
Oct 13, 2024
…ic#113491) This copies the work from apache/lucene#13651 into Elasticsearch. The main reason for the copy is to simply allow it to be deployed & used in Elasticsearch prior to Elasticsearch upgrading to Lucene 10. At which point, we will then use the format as provided by Lucene. This is currently blocked by two pieces of work: blocked by: elastic#112933 blocked by: elastic#113333 After the format is merged, then code will be added for integration tests & integration with Elasticsearch through new index format types in the API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to Lucene 9.12
This PR will be squash-merged, so as to simplify the backport to the 8.x branch.