Skip to content

[DOCS] Fix typos of docs/plugins #113348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2024
Merged

[DOCS] Fix typos of docs/plugins #113348

merged 1 commit into from
Sep 23, 2024

Conversation

YeonghyeonKO
Copy link
Contributor

I've fixed typos of docs/plugins.

Discussion:

  • docs/plugins/store-smb.asciidoc
    • I think the main subject and verb of the below sentence should be 'the way' and 'is', respectively. It means that the phrase "Lucene open index segment files" is a modifying or descriptive clause that explains how "the way" is carried out. Because the word "Lucene" is singular, the verb of this clause should be "opens", not "open".

When using a shared file system based on the SMB protocol (like Azure File Service) to store indices, the way Lucene
open -> opens index segment files is with a write only flag.


  • docs/plugins/development/creating-stable-plugins.asciidoc
    • The lint for text hasn't been applied in the file(docs/plugins/development/creating-stable-plugins.asciidoc) so unnecessary spaces is deleted now.

@github-actions GitHub Actions
Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added v9.0.0 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Sep 22, 2024
@gbanasiak gbanasiak added >docs General docs changes Team:Docs Meta label for docs team labels Sep 23, 2024
@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Sep 23, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@leemthompo leemthompo self-assigned this Sep 23, 2024
@leemthompo
Copy link
Contributor

@elasticmachine test this

@leemthompo
Copy link
Contributor

run docs-build

leemthompo
leemthompo approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice fixes, thanks @YeonghyeonKO 🔎 ✎ 👏

@leemthompo leemthompo merged commit 2a5afca into elastic:main Sep 23, 2024
8 checks passed
leemthompo pushed a commit to leemthompo/elasticsearch that referenced this pull request Sep 23, 2024
@YeonghyeonKO @leemthompo
fix typos of docs/plugins (elastic#113348)
8411db1
@leemthompo leemthompo mentioned this pull request Sep 23, 2024
Merged
leemthompo pushed a commit to leemthompo/elasticsearch that referenced this pull request Sep 23, 2024
@YeonghyeonKO @leemthompo
fix typos of docs/plugins (elastic#113348)
29dad37
@leemthompo leemthompo mentioned this pull request Sep 23, 2024
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.15
✅ 8.x

elasticsearchmachine pushed a commit that referenced this pull request Sep 23, 2024
@leemthompo @YeonghyeonKO
fix typos of docs/plugins (#113348) (#113403)
2f7b444 
Co-authored-by: YeonghyeonKo <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Sep 23, 2024
@leemthompo @YeonghyeonKO
fix typos of docs/plugins (#113348) (#113404)
2fac37d 
Co-authored-by: YeonghyeonKo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leemthompo leemthompo leemthompo approved these changes

Assignees

@leemthompo leemthompo

Labels

>docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v8.15.0 v8.16.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@YeonghyeonKO @elasticsearchmachine @leemthompo @gbanasiak