Skip to content

Conversation

stefnestor
Copy link
Contributor

Follow-up to #111951, links ES CAT API's to their parent objects for cross-reference-ability.

@stefnestor stefnestor added >enhancement >docs General docs changes Team:Docs Meta label for docs team auto-backport-and-merge labels Sep 25, 2024
Copy link
Contributor

Documentation preview:

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine elasticsearchmachine added v9.0.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Sep 25, 2024
@lcawl
Copy link
Contributor

lcawl commented Sep 25, 2024

Linking to elastic/elasticsearch-specification#2748 since we'll ultimately need to implement these links in the Elasticsearch specifications.

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs build error is related to two little broken links

@stefnestor stefnestor requested a review from a team September 25, 2024 16:59
Co-authored-by: Lisa Cawley <[email protected]>
@stefnestor
Copy link
Contributor Author

Changes accepted, cheers. Ready again 🙏

@mark-vieira mark-vieira added auto-backport Automatically create backport pull requests when merged and removed auto-backport-and-merge labels Oct 4, 2024
Copy link
Contributor

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of comments and suggestions for you :)

@stefnestor
Copy link
Contributor Author

Ready again, @shainaraskas ! 🙏

Copy link
Contributor

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks

@stefnestor stefnestor merged commit 612ce0f into elastic:main Oct 9, 2024
5 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

The backport operation could not be completed due to the following error:

An unexpected error occurred when attempting to backport this PR.

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 113541

matthewabbott pushed a commit to matthewabbott/elasticsearch that referenced this pull request Oct 10, 2024
* (Doc+) Cross-link CAT APIs to parent object

---------

Co-authored-by: Lisa Cawley <[email protected]>
Co-authored-by: shainaraskas <[email protected]>
davidkyle pushed a commit to davidkyle/elasticsearch that referenced this pull request Oct 13, 2024
* (Doc+) Cross-link CAT APIs to parent object

---------

Co-authored-by: Lisa Cawley <[email protected]>
Co-authored-by: shainaraskas <[email protected]>
@stefnestor stefnestor deleted the stef_catApisXlinks branch November 15, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged backport pending >docs General docs changes >enhancement external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v8.15.0 v8.16.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants