Add some information on locale database to the ES docs #113587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecoop
added
>docs
|
Documentation preview: |
|
Pinging @elastic/es-docs (Team:Docs) |
elasticsearchmachine
added
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
thecoop
added
v7.17.25
auto-backport
prdoyle
reviewed
Sep 26, 2024
thecoop
removed
the
auto-backport
prdoyle
approved these changes
Sep 27, 2024
| with ingest, output, and re-indexing. It is recommended to always use numerical fields in custom date formats, | ||
| which are not affected by locale information. | ||
|
|
||
| There can also be differences in week-date calculations using the `Y`, `W`, and `w` field specifiers. |
There was a problem hiding this comment.
I love how explicit the list of field specifiers is.
Would it make sense to word this advice such that we could add these three stragglers to the bullet list above, to provide one-stop-shopping for users who want to ensure they avoid this problem? I could envision a user swiping the above list and pasting it into a Jira ticket, thereby missing these three.
There was a problem hiding this comment.
Possibly, however the effects are quite different for each type, and I expect users to read the whole doc
| A formatter for a full date as four digit weekyear, two digit week of | ||
| weekyear, and one digit day of week: `xxxx-'W'ww-e`. | ||
| weekyear, and one digit day of week: `YYYY-'W'ww-e`. | ||
| This uses the ISO week-date definition. |
thecoop
added a commit
to thecoop/elasticsearch
that referenced
this pull request
Sep 30, 2024
This was referenced Sep 30, 2024
thecoop
added a commit
that referenced
this pull request
Oct 1, 2024
thecoop
added a commit
that referenced
this pull request
Oct 2, 2024
gmarouli
pushed a commit
to gmarouli/elasticsearch
that referenced
this pull request
Oct 3, 2024
…stic#113870) Forward-port changes from elastic#113787, and update the docs with similar information to elastic#113587
matthewabbott
pushed a commit
to matthewabbott/elasticsearch
that referenced
this pull request
Oct 4, 2024
…stic#113870) Forward-port changes from elastic#113787, and update the docs with similar information to elastic#113587
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There needs to be some reference to locale database in the docs