Skip to content

Add link to NO_COPIES allocation explain message #113656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2024
Merged

Add link to NO_COPIES allocation explain message #113656

merged 2 commits into from
Oct 10, 2024

Conversation

matthewabbott
Copy link
Contributor

Adds no_valid_shard_copies reference link to the NO_COPIES allocation explanations string

@matthewabbott matthewabbott added >non-issue :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. Supportability Improve our (devs, SREs, support eng, users) ability to troubleshoot/self-service product better. labels Sep 27, 2024
@elasticsearchmachine elasticsearchmachine added v9.0.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Sep 27, 2024
@matthewabbott matthewabbott added >docs General docs changes and removed >docs General docs changes labels Sep 27, 2024
DaveCTurner
DaveCTurner reviewed Sep 27, 2024
View reviewed changes
@stefnestor stefnestor mentioned this pull request Sep 27, 2024
Merged
@matthewabbott matthewabbott force-pushed the matthewabbot_edit_allocation_explain branch from 667b0c2 to 19a3f59 Compare October 4, 2024 00:56
@matthewabbott matthewabbott marked this pull request as ready for review October 4, 2024 23:37
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

DaveCTurner
DaveCTurner reviewed Oct 9, 2024
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits otherwise LGTM

DaveCTurner
DaveCTurner approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthewabbott matthewabbott requested review from a team as code owners October 10, 2024 19:51
mark-vieira
mark-vieira previously requested changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there might have been some kind of merge or rebase issue here as there are a ton of completely unrelated changes in this PR.

@matthewabbott
Copy link
Contributor Author

Yeah I’ll get that fixed up RE: rebase issue. Sorry about that.

@matthewabbott matthewabbott force-pushed the matthewabbot_edit_allocation_explain branch from cedcbbc to 5d3f909 Compare October 10, 2024 20:56
@DaveCTurner DaveCTurner dismissed mark-vieira’s stale review October 10, 2024 21:03

fixed (with a force-push)

@matthewabbott matthewabbott merged commit a0cd389 into elastic:main Oct 10, 2024
16 checks passed
@matthewabbott matthewabbott deleted the matthewabbot_edit_allocation_explain branch October 10, 2024 22:11
davidkyle pushed a commit to davidkyle/elasticsearch that referenced this pull request Oct 13, 2024
@matthewabbott @davidkyle
Add link to NO_COPIES allocation explain message (elastic#113656)
a5f481c 
* tweaked no-valid-shard-copies message

* untweaked misformatting in allocation explain asciidoc
@stefnestor stefnestor mentioned this pull request Oct 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stefnestor stefnestor stefnestor left review comments

@DaveCTurner DaveCTurner DaveCTurner approved these changes

@mark-vieira mark-vieira mark-vieira left review comments

Assignees

No one assigned

Labels

:Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) external-contributor Pull request authored by a developer outside the Elasticsearch team >non-issue Supportability Improve our (devs, SREs, support eng, users) ability to troubleshoot/self-service product better. Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@matthewabbott @elasticsearchmachine @mark-vieira @DaveCTurner @stefnestor