Skip to content

[DOCS] Documents that embeddings are filtered out from semantic_text results #113701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 18 commits into from
Closed

[DOCS] Documents that embeddings are filtered out from semantic_text results #113701

wants to merge 18 commits into from

Conversation

szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Sep 27, 2024 •
edited
Loading

Overview

When displayed in an API response for semantic_text fields, the embeddings are automatically filtered out from _source. This PR changes the API results in the documentation and documents the include_vectors parameter in _source documentation.

Preview

@szabosteve szabosteve added >docs General docs changes :Search/Search Search-related issues that do not fall into other categories Team:Docs Meta label for docs team auto-backport-and-merge v8.16.0 labels Sep 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added Team:Search Meta label for search team v9.0.0 labels Sep 27, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

szabosteve
szabosteve commented Sep 27, 2024
View reviewed changes
@szabosteve szabosteve marked this pull request as draft September 27, 2024 16:01
@szabosteve
Copy link
Contributor Author

@elasticsearchmachine update branch

szabosteve
szabosteve commented Oct 1, 2024
View reviewed changes
@szabosteve szabosteve marked this pull request as ready for review October 1, 2024 13:44
@szabosteve szabosteve requested a review from Mikep86 October 1, 2024 13:44
@mark-vieira mark-vieira added auto-backport Automatically create backport pull requests when merged and removed auto-backport-and-merge labels Oct 4, 2024
@Mikep86
Copy link
Contributor

Mikep86 commented Oct 16, 2024

@szabosteve We can close this PR. we are no longer going to implement this filtering, instead we are going to change how semantic text field values are stored in source.

@szabosteve
Copy link
Contributor Author

@Mikep86 Thanks for the heads-up! I'm closing this.

@szabosteve szabosteve closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mikep86 Mikep86 Awaiting requested review from Mikep86

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged >docs General docs changes :Search/Search Search-related issues that do not fall into other categories Team:Docs Meta label for docs team Team:Search Meta label for search team v8.16.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@szabosteve @elasticsearchmachine @Mikep86 @mark-vieira @lcawl