Skip to content

ES|QL: pin 'now' as query start time #113777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 1, 2024
Merged

ES|QL: pin 'now' as query start time #113777

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee96e24
ES|QL: pin 'now' as query start time
luigidellaquila Sep 30, 2024
6e31a34
Javadoc
luigidellaquila Sep 30, 2024
a7ad3bb
Merge branch 'main' into esql/pin_now
luigidellaquila Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/session/Configuration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,11 +171,9 @@ public String query() {
/**
* Returns the current time in milliseconds from the time epoch for the execution of this request.
* It ensures consistency by using the same value on all nodes involved in the search request.
* Note: Currently, it returns {@link System#currentTimeMillis()}, but this value will be serialized between nodes.
*/
public long absoluteStartedTimeInMillis() {
// MP TODO: I'm confused - Why is this not a fixed value taken at the start of the query processing?
return System.currentTimeMillis();
return now.toInstant().toEpochMilli();
}

/**
Expand Down