Simplifying the way the simulate ingest API uses component template substitutions for pipeline lookup and mapping validation #113908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ubstitutions for mapping validation
masseyke
added
>non-issue
:Data Management/Ingest Node
|
Pinging @elastic/es-data-management (Team:Data Management) |
elasticsearchmachine
added
the
Team:Data Management
…he pipeline-lookup side of simulate ingest
masseyke
commented
Oct 2, 2024
| } | ||
| } | ||
|
|
||
| public void testResolvePipelinesAndUpdateIndexRequestWithComponentTemplateSubstitutions() throws IOException { |
There was a problem hiding this comment.
This test could be deleted because IngestService no longer knows anything about component template substitutions.
masseyke
changed the title
gmarouli
reviewed
Oct 3, 2024
server/src/main/java/org/elasticsearch/action/bulk/TransportAbstractBulkAction.java
Show resolved
Hide resolved
| * we don't fall back to the existing index if we don't find any because it is possible the user has intentionally removed the | ||
| * pipeline. | ||
| */ | ||
| final Pipelines pipelines; |
There was a problem hiding this comment.
We need to update this comment and mention that in order of the simulation to work we would need to remove any existing index/data stream. I am thinking that now this can easily be missed.
There was a problem hiding this comment.
Oh good point! I had forgotten about this comment.
Comment on lines
187
to
190
| /* | ||
| * If this is a simulated request, and there are template substitutions, then we want to create and use a new metadata that has | ||
| * those templates. | ||
| */ |
There was a problem hiding this comment.
I think it will be really helpful to refer here to the methods that require this to work properly.
There was a problem hiding this comment.
I added a bit here. Let me know if there's something else that would be helpful.
gmarouli
reviewed
Oct 4, 2024
| - not_exists: docs.0.doc.error | ||
|
|
||
| --- | ||
| "Test ingest simulate with component template substitutions for data streams": |
masseyke
deleted the
simplify-simulate-ingest-component-template-substitutions
branch
💚 Backport successful
|
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Oct 4, 2024
…ubstitutions for pipeline lookup and mapping validation (elastic#113908)
matthewabbott
pushed a commit
to matthewabbott/elasticsearch
that referenced
this pull request
Oct 10, 2024
…ubstitutions for pipeline lookup and mapping validation (elastic#113908)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the way that component template substitutions are passed around for mapping validation. Instead of separately passing them throughout the stack, TransportSimulateBulkAction now puts them int its simulatedState (a modified cluster state that is only used for the duration of the request).
A nice side effect of this change is that it makes some upcoming work to allow for index template substitutions much easier.
This relates to #113276, #112957, and #113063.