-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Updated Date Range to Follow Documentation When Assuming Missing Values - Yaml Compat Doc Updates #113964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
john-wagster
merged 12 commits into
elastic:main
from
john-wagster:rest-compat-yaml-docs-backport-update
Mar 20, 2025
Merged
Updated Date Range to Follow Documentation When Assuming Missing Values - Yaml Compat Doc Updates #113964
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c2bf2eb
updating yaml compat docs
john-wagster 95d7986
Merge branch 'main' into rest-compat-yaml-docs-backport-update
elasticmachine f668684
iter
john-wagster bb3abeb
Merge branch 'main' into rest-compat-yaml-docs-backport-update
john-wagster 3d83f8c
iter
john-wagster 2bbd15d
Merge branch 'main' into rest-compat-yaml-docs-backport-update
elasticmachine d9926b0
Update REST_API_COMPATIBILITY.md
john-wagster 49d7f78
Update REST_API_COMPATIBILITY.md
john-wagster c192754
iter
john-wagster 819d774
Merge branch 'main' into rest-compat-yaml-docs-backport-update
elasticmachine db51108
Merge branch 'main' into rest-compat-yaml-docs-backport-update
john-wagster 53628b5
iter
john-wagster File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still leaving me wondering what I need to do here (sorry, perhaps it's a "me" problem - bwc is mind twisting :) )
Just so I understand correctly:
When skipping a test temporarily in 9.0.0, we have to implement the proper
skipandrequiresconditions to previous branches, such as 8.latest. After these conditions are implemented in 8.latest, you can re-enable the test in 9.0.0 by removing the skipTest condition.The team implementing the changes can decide how to clean up or modify tests based on how breaking changes were backported. e.g.:
In 8.latest:
requires/skipconditions to existing tests that check the old behavior. This prevents those tests from failing during backward compatibility or upgrade testing from 8.latest to 9.0.0In 9.0.0:
Is this a correct summary? If so, can we rephrase this paragraph to something similar ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreidan completely fine with the rewrite here and agree it helps; updated to reflect your suggestion (with only minor changes to the wording). Let me know if you feel good about that update and I'll wait a bit for any additional feedback and then merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating here. LGTM