-
Notifications
You must be signed in to change notification settings - Fork 25.6k
ESQL: Entirely remove META FUNCTIONS #113967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
0ddd85f
ESQL: Entirely remove META FUNCTIONS
nik9000 cdf0045
Update docs/changelog/113967.yaml
nik9000 b9ec964
Update docs/changelog/113967.yaml
nik9000 115a114
Explain
nik9000 2919d3e
Merge branch 'main' into esql_no_meta
nik9000 7879bab
Merge branch 'main' into esql_no_meta
nik9000 3a224a3
Drop:
nik9000 ee01dae
Merge branch 'main' into esql_no_meta
nik9000 356c13e
Merge branch 'main' into esql_no_meta
nik9000 6520daa
Merge branch 'main' into esql_no_meta
nik9000 18c69f5
ESQL: Entirely remove META
nik9000 565da1b
Merge branch 'main' into esql_no_meta
nik9000 3cf1ea8
Extra
nik9000 0418a51
Format
nik9000 65daa66
Remove another reference
nik9000 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
pr: 113967 | ||
summary: "ESQL: Entirely remove META FUNCTIONS" | ||
area: ES|QL | ||
type: breaking | ||
issues: [] | ||
breaking: | ||
title: "ESQL: Entirely remove META FUNCTIONS" | ||
area: ES|QL | ||
details: | | ||
Removes an undocumented syntax from ESQL: META FUNCTION. This was never | ||
reliable or really useful. Consult the documentation instead. | ||
impact: "Removes an undocumented syntax from ESQL: META FUNCTION" | ||
notable: false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -72,10 +72,6 @@ public MixedClusterEsqlSpecIT( | |
protected void shouldSkipTest(String testName) throws IOException { | ||
super.shouldSkipTest(testName); | ||
assumeTrue("Test " + testName + " is skipped on " + bwcVersion, isEnabled(testName, instructions, bwcVersion)); | ||
assumeFalse( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should the similar be removed from MultiClusterSpecIT class as well? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
"Skip META tests on mixed version clusters because we change it too quickly", | ||
testCase.requiredCapabilities.contains("meta") | ||
); | ||
if (mode == ASYNC) { | ||
assumeTrue("Async is not supported on " + bwcVersion, supportsAsync()); | ||
} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
552 changes: 0 additions & 552 deletions
552
x-pack/plugin/esql/qa/testFixtures/src/main/resources/meta.csv-spec
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍