Skip to content

Rollback Semantic Query Inner Hits #113986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2024
Merged

Rollback Semantic Query Inner Hits #113986

merged 2 commits into from
Oct 3, 2024

Conversation

Mikep86
Copy link
Contributor

@Mikep86 Mikep86 commented Oct 2, 2024 •
edited
Loading

Removes the inner_hits param and the underlying implementation from semantic query.

Rolls back #111834

@Mikep86 Mikep86 added >non-issue auto-backport-and-merge :Search Relevance/Vectors Vector search :SearchOrg/Relevance Label for the Search (solution/org) Relevance team v8.16.0 :Search Relevance/Search Catch all for Search Relevance v9.0.0 labels Oct 2, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-eng (Team:SearchOrg)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-relevance (Team:Search - Relevance)

carlosdelest
carlosdelest requested changes Oct 3, 2024
View reviewed changes
Copy link
Member

@carlosdelest carlosdelest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Mikep86 , I think you need to roll back the changes to the semantic-query.asciidoc file here.

The rest LGTM 👍

carlosdelest
carlosdelest approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@carlosdelest carlosdelest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see you removed docs in a different PR. LGTM!

@Mikep86 Mikep86 merged commit 08fb7c0 into elastic:main Oct 3, 2024
15 of 16 checks passed
Mikep86 added a commit to Mikep86/elasticsearch that referenced this pull request Oct 3, 2024
@Mikep86
Rollback Semantic Query Inner Hits (elastic#113986)
663a58d
@Mikep86 Mikep86 mentioned this pull request Oct 3, 2024
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.x

elasticsearchmachine pushed a commit that referenced this pull request Oct 4, 2024
@Mikep86 @elasticmachine
Rollback Semantic Query Inner Hits (#113986) (#114027)
01a4c2a 
Co-authored-by: Elastic Machine <[email protected]>
matthewabbott pushed a commit to matthewabbott/elasticsearch that referenced this pull request Oct 4, 2024
@Mikep86 @matthewabbott
Rollback Semantic Query Inner Hits (elastic#113986)
e1a628d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlosdelest carlosdelest carlosdelest approved these changes

@kderusso kderusso kderusso approved these changes

@jimczi jimczi Awaiting requested review from jimczi

Assignees

No one assigned

Labels

>non-issue :Search Relevance/Search Catch all for Search Relevance :Search Relevance/Vectors Vector search :SearchOrg/Relevance Label for the Search (solution/org) Relevance team v8.16.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Mikep86 @elasticsearchmachine @carlosdelest @kderusso