Skip to content

Conversation

DaveCTurner
Copy link
Contributor

Today the docs for the ?wait_for_active_shards parameter say that it
must be a positive integer, proscribing 0, yet 0 is a legitimate
value for this parameter. This commit fixes this point and rewords the
docs slightly for clarity.

Today the docs for the `?wait_for_active_shards` parameter say that it
must be a positive integer, proscribing `0`, yet `0` is a legitimate
value for this parameter. This commit fixes this point and rewords the
docs slightly for clarity.
@DaveCTurner DaveCTurner added >docs General docs changes :Data Management/Indices APIs APIs to create and manage indices and templates v8.16.0 v9.0.0 v8.15.3 auto-backport-and-merge labels Oct 4, 2024
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Documentation preview:

@elasticsearchmachine elasticsearchmachine added Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team labels Oct 4, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@DaveCTurner DaveCTurner requested a review from dakrone October 4, 2024 10:44
@mark-vieira mark-vieira added auto-backport Automatically create backport pull requests when merged and removed auto-backport-and-merge labels Oct 4, 2024
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner added auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) and removed auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Oct 8, 2024
@DaveCTurner DaveCTurner enabled auto-merge (squash) October 8, 2024 05:39
@DaveCTurner DaveCTurner merged commit 740cb2e into elastic:main Oct 8, 2024
4 of 5 checks passed
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Oct 8, 2024
Today the docs for the `?wait_for_active_shards` parameter say that it
must be a positive integer, proscribing `0`, yet `0` is a legitimate
value for this parameter. This commit fixes this point and rewords the
docs slightly for clarity.
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Oct 8, 2024
Today the docs for the `?wait_for_active_shards` parameter say that it
must be a positive integer, proscribing `0`, yet `0` is a legitimate
value for this parameter. This commit fixes this point and rewords the
docs slightly for clarity.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.x
8.15

elasticsearchmachine pushed a commit that referenced this pull request Oct 8, 2024
…4273)

Today the docs for the `?wait_for_active_shards` parameter say that it
must be a positive integer, proscribing `0`, yet `0` is a legitimate
value for this parameter. This commit fixes this point and rewords the
docs slightly for clarity.
elasticsearchmachine pushed a commit that referenced this pull request Oct 8, 2024
…4274)

Today the docs for the `?wait_for_active_shards` parameter say that it
must be a positive integer, proscribing `0`, yet `0` is a legitimate
value for this parameter. This commit fixes this point and rewords the
docs slightly for clarity.
matthewabbott pushed a commit to matthewabbott/elasticsearch that referenced this pull request Oct 10, 2024
Today the docs for the `?wait_for_active_shards` parameter say that it
must be a positive integer, proscribing `0`, yet `0` is a legitimate
value for this parameter. This commit fixes this point and rewords the
docs slightly for clarity.
davidkyle pushed a commit to davidkyle/elasticsearch that referenced this pull request Oct 13, 2024
Today the docs for the `?wait_for_active_shards` parameter say that it
must be a positive integer, proscribing `0`, yet `0` is a legitimate
value for this parameter. This commit fixes this point and rewords the
docs slightly for clarity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged :Data Management/Indices APIs APIs to create and manage indices and templates >docs General docs changes Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v8.15.3 v8.16.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants