-
Notifications
You must be signed in to change notification settings - Fork 25.5k
Add telemetry for retrievers #114109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add telemetry for retrievers #114109
Conversation
Documentation preview: |
Hi @pmpailis, I've created a changelog YAML for you. |
…asticsearch into add_telemetry_for_retrievers
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
@elasticmachine update branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Should we add an AbstractBWCSerializationTestCase
now that the format has changed for ClusterStats
?
...er/src/internalClusterTest/java/org/elasticsearch/search/retriever/RetrieverTelemetryIT.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/search/retriever/RetrieverBuilder.java
Outdated
Show resolved
Hide resolved
...ticsearch/xpack/inference/rank/textsimilarity/TextSimilarityRankRetrieverTelemetryTests.java
Show resolved
Hide resolved
Co-authored-by: Carlos Delgado <[email protected]>
The main change lies in how @carlosdelest do you think that this would be enough, or should we add a new test class for the top level |
@elasticmachine update branch |
@pmpailis , absolutely! Thanks for pointing that out 👍 |
@elasticmachine update branch |
run elasticsearch-ci/part-1 |
@elasticmachine update branch |
run elasticsearch-ci/packaging-tests-windows-sample |
@elasticmachine update branch |
💚 Backport successful
|
This is to update the information present in
ClusterStats
for retrievers. The proposed approach is to introduce a new element namedretriever
undersections
that would compute just the top-level usages of a retriever, and additionally a new section namedretrievers
that would contain the names of all the retrievers used anywhere in the tree, i.e. all top-level usages of a retriever + any nested retrievers used (e.g. children ofrrf
ortext_similarity_reranker
)So assuming that we run a
knn
retriever search, and anrrf
with astandard
and aknn
as direct children, the suggested output would now be: