Revert "Fix BWC for file-settings based role mappings (#113900)" and related #114326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1v0lg
added
>non-issue
:Security/Authentication
jakelandis
approved these changes
Oct 8, 2024
|
CI failure was unrelated: https://gradle-enterprise.elastic.co/s/npgurfby72vjg |
@jakelandis yup, just three reverts |
|
@elasticmachine update branch |
|
Pinging @elastic/es-security (Team:Security) |
n1v0lg
added
auto-merge-without-approval
|
@elasticmachine update branch |
n1v0lg
added
the
auto-merge-without-approval
|
@elasticmachine update branch |
|
Discussed with es-delivery: the CI job is stuck on an non-test-related step so I'm force merging without waiting for job completion. |
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Oct 9, 2024
…" and related (elastic#114326) Revert "Fix BWC for file-settings based role mappings (elastic#113900)" and related changes. Reverted commits: - 763764c - bc8f9dc - ce07060 This is due to a bug in the above fix. We will reintroduce a paired down version of the fix in a subsequent PR. (cherry picked from commit f389623)
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Oct 9, 2024
…" and related (elastic#114326) Revert "Fix BWC for file-settings based role mappings (elastic#113900)" and related changes. Reverted commits: - 763764c - bc8f9dc - ce07060 This is due to a bug in the above fix. We will reintroduce a paired down version of the fix in a subsequent PR. (cherry picked from commit f389623) # Conflicts: # x-pack/plugin/security/src/internalClusterTest/java/org/elasticsearch/integration/RoleMappingFileSettingsIT.java # x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/action/role/TransportDeleteRoleAction.java # x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/action/rolemapping/TransportDeleteRoleMappingAction.java # x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/action/rolemapping/TransportPutRoleMappingAction.java
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
n1v0lg
pushed a commit
that referenced
this pull request
Oct 9, 2024
n1v0lg
pushed a commit
that referenced
this pull request
Oct 9, 2024
matthewabbott
pushed a commit
to matthewabbott/elasticsearch
that referenced
this pull request
Oct 10, 2024
…" and related (elastic#114326) Revert "Fix BWC for file-settings based role mappings (elastic#113900)" and related changes. Reverted commits: - 763764c - bc8f9dc - ce07060 This is due to a bug in the above fix. We will reintroduce a paired down version of the fix in a subsequent PR.
davidkyle
pushed a commit
to davidkyle/elasticsearch
that referenced
this pull request
Oct 13, 2024
…" and related (elastic#114326) Revert "Fix BWC for file-settings based role mappings (elastic#113900)" and related changes. Reverted commits: - 763764c - bc8f9dc - ce07060 This is due to a bug in the above fix. We will reintroduce a paired down version of the fix in a subsequent PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "Fix BWC for file-settings based role mappings (#113900)" and related changes. Reverted commits:
This is due to a bug in the above fix. We will reintroduce a paired down version of the fix in a subsequent PR.