Skip to content

Conversation

PeteGillinElastic
Copy link
Member

@PeteGillinElastic PeteGillinElastic commented Oct 9, 2024

A docs page for the terminate processor was added in #114157, but the change to include it in the outer processor reference page was omitted. This change corrects that oversight.

closes #110218

A docs page for the `terminate` processor was added in
elastic#114157, but the change
to include it in the outer processor reference page was omitted. This
change corrects that oversight.
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Documentation preview:

@PeteGillinElastic PeteGillinElastic added :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >docs General docs changes v8.16.0 auto-backport Automatically create backport pull requests when merged labels Oct 9, 2024
@PeteGillinElastic
Copy link
Member Author

The 'Documentation preview' link added by GHA above seems to 404. But I have built the docs locally with $HOME/docs/build_docs --doc $HOME/elasticsearch/docs/reference/index.asciidoc --open and it looks okay.

@PeteGillinElastic PeteGillinElastic marked this pull request as ready for review October 9, 2024 18:00
@elasticsearchmachine elasticsearchmachine added Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team labels Oct 9, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch!

@PeteGillinElastic PeteGillinElastic merged commit c8c6f5a into elastic:main Oct 10, 2024
7 checks passed
@PeteGillinElastic PeteGillinElastic deleted the docs/110218 branch October 10, 2024 07:34
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.x

PeteGillinElastic added a commit to PeteGillinElastic/elasticsearch that referenced this pull request Oct 10, 2024
A docs page for the `terminate` processor was added in
elastic#114157, but the change
to include it in the outer processor reference page was omitted. This
change corrects that oversight.
elasticsearchmachine pushed a commit that referenced this pull request Oct 10, 2024
A docs page for the `terminate` processor was added in
#114157, but the change
to include it in the outer processor reference page was omitted. This
change corrects that oversight.
@leemthompo
Copy link
Contributor

leemthompo commented Oct 10, 2024

The 'Documentation preview' link added by GHA above seems to 404.

@PeteGillinElastic FYI the link won't be live until the first successful build on the PR :)

But I have built the docs locally

Nice!🏅

@PeteGillinElastic
Copy link
Member Author

The 'Documentation preview' link added by GHA above seems to 404.

@PeteGillinElastic FYI the link won't be live until the first successful build on the PR :)

Yeah, I noticed that it was working later. Thanks.

matthewabbott pushed a commit to matthewabbott/elasticsearch that referenced this pull request Oct 10, 2024
A docs page for the `terminate` processor was added in
elastic#114157, but the change
to include it in the outer processor reference page was omitted. This
change corrects that oversight.
davidkyle pushed a commit to davidkyle/elasticsearch that referenced this pull request Oct 13, 2024
A docs page for the `terminate` processor was added in
elastic#114157, but the change
to include it in the outer processor reference page was omitted. This
change corrects that oversight.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >docs General docs changes Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v8.16.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ingest node: terminate processor

4 participants