-
Notifications
You must be signed in to change notification settings - Fork 25.5k
Actually add terminate
docs page
#114440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actually add terminate
docs page
#114440
Conversation
A docs page for the `terminate` processor was added in elastic#114157, but the change to include it in the outer processor reference page was omitted. This change corrects that oversight.
Documentation preview: |
The 'Documentation preview' link added by GHA above seems to 404. But I have built the docs locally with |
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-data-management (Team:Data Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good catch!
💚 Backport successful
|
A docs page for the `terminate` processor was added in elastic#114157, but the change to include it in the outer processor reference page was omitted. This change corrects that oversight.
A docs page for the `terminate` processor was added in #114157, but the change to include it in the outer processor reference page was omitted. This change corrects that oversight.
@PeteGillinElastic FYI the link won't be live until the first successful build on the PR :)
Nice!🏅 |
Yeah, I noticed that it was working later. Thanks. |
A docs page for the `terminate` processor was added in elastic#114157, but the change to include it in the outer processor reference page was omitted. This change corrects that oversight.
A docs page for the `terminate` processor was added in elastic#114157, but the change to include it in the outer processor reference page was omitted. This change corrects that oversight.
A docs page for the
terminate
processor was added in #114157, but the change to include it in the outer processor reference page was omitted. This change corrects that oversight.closes #110218