Remove the failures field from snapshot responses
#114496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failure handling for snapshots was made stricter in elastic#107191 (8.15), so this field is always empty since then. Clients don't need to check it anymore for failure handling, we can remove it from API responses in 9.0
arteam
added
WIP
:Distributed Coordination/Snapshot/Restore
arteam
requested review from
DaveCTurner and
original-brownbear
and removed request for
original-brownbear
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
arteam
added
>refactoring
and removed
Team:Distributed (Obsolete)
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
nicktindall
reviewed
Oct 22, 2024
...src/main/java/org/elasticsearch/action/admin/cluster/snapshots/get/GetSnapshotsResponse.java
Show resolved
Hide resolved
|
Happy to re-review once bwc stuff is in place! |
|
@elasticmachine update branch |
DaveCTurner
requested changes
Oct 28, 2024
elasticsearchmachine
added
v9.1.0
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-obsolete (Team:Distributed (Obsolete)) |
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
arteam
force-pushed
the
remove-snapshot-failures
branch
from
81fef7e to
7ecfe8f
Compare
DaveCTurner
approved these changes
Feb 5, 2025
...src/main/java/org/elasticsearch/action/admin/cluster/snapshots/get/GetSnapshotsResponse.java
Show resolved
Hide resolved
...src/main/java/org/elasticsearch/action/admin/cluster/snapshots/get/GetSnapshotsResponse.java
Show resolved
Hide resolved
arteam
added
auto-backport
💔 Backport failed
You can use sqren/backport to manually backport by running |
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Feb 5, 2025
…4496) Backports elastic#114496 to 9.0 > Failure handling for snapshots was made stricter in elastic#107191 (8.15), so this field is always empty since then. Clients don't need to check it anymore for failure handling, we can remove it from API responses in 9.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failure handling for snapshots was made stricter in #107191 (8.15), so this field is always empty since then. Clients don't need to check it anymore for failure handling, we can remove it from API responses in 9.0