Skip to content

review term-query examples #114519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

review term-query examples #114519

wants to merge 1 commit into from

Conversation

georgewallace
Copy link
Contributor

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@github-actions GitHub Actions
Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added v9.0.0 needs:triage Requires assignment of a team area label labels Oct 10, 2024
@georgewallace georgewallace added >docs General docs changes Team:Docs Meta label for docs team labels Oct 10, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Oct 10, 2024
szabosteve
szabosteve approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know //REVIEWED[10.10.24] was my original suggestion but // REVIEWED[OCT. 10.24] would be more univocal. I left commitable suggestions to change the data format. Otherwise, LGTM!

docs/reference/query-dsl/term-query.asciidoc
}
}
----
// REVIEWED[10.10.24]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way, it'll be unambiguous.

Suggested change
// REVIEWED[10.10.24]
// REVIEWED[OCT. 10.24]

docs/reference/query-dsl/term-query.asciidoc
}
----

// REVIEWED[10.10.24]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// REVIEWED[10.10.24]
// REVIEWED[OCT. 10.24]

docs/reference/query-dsl/term-query.asciidoc
----
// TEST[continued]

// REVIEWED[10.10.24]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// REVIEWED[10.10.24]
// REVIEWED[OCT. 10.24]

docs/reference/query-dsl/term-query.asciidoc
----
// TEST[continued]

// REVIEWED[10.10.24]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// REVIEWED[10.10.24]
// REVIEWED[OCT. 10.24]

docs/reference/query-dsl/term-query.asciidoc
----
// TEST[continued]
// REVIEWED[10.10.24]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// REVIEWED[10.10.24]
// REVIEWED[OCT. 10.24]

docs/reference/query-dsl/term-query.asciidoc
----
// TEST[continued]

// REVIEWED[10.10.24]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// REVIEWED[10.10.24]
// REVIEWED[OCT. 10.24]

docs/reference/query-dsl/term-query.asciidoc
----
// TESTRESPONSE[s/"took" : 1/"took" : $body.took/]
--
// REVIEWED[10.10.24]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// REVIEWED[10.10.24]
// REVIEWED[OCT. 10.24]

@leemthompo
Copy link
Contributor

FYI I went with // REVIEWED[OCT.28.2024] syntax in a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szabosteve szabosteve szabosteve approved these changes

Assignees

No one assigned

Labels

>docs General docs changes Team:Docs Meta label for docs team v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@georgewallace @elasticsearchmachine @leemthompo @szabosteve