Skip to content

Avoid throw exception in SyntheticSourceIndexSettingsProvider #114662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2024
Merged

Avoid throw exception in SyntheticSourceIndexSettingsProvider #114662

merged 1 commit into from
Oct 11, 2024

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Oct 11, 2024 •
edited
Loading

Backport of #114479:

  • Move buildIndexMetadata inside a try/catch block to prevent errors, as SyntheticSourceIndexSettingsProvider can use a incomplete settings to build an IndexMetadata.
  • Update documentation for index_routing_shards.

@github-actions GitHub Actions
Copy link
Contributor

Documentation preview:

@dnhatn dnhatn marked this pull request as ready for review October 11, 2024 22:25
@dnhatn dnhatn merged commit db02d9b into elastic:8.x Oct 11, 2024
16 checks passed
@dnhatn dnhatn deleted the fix-routing-settings branch October 11, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport v8.16.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dnhatn @elasticsearchmachine